Repository navigation
[CI] Remove duplicate terminal backlog test replays - #27503
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The consolidated tests retain the checks removed from the duplicate replays. No merge-blocking issue was found; ordinary CI remains pending. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title clearly and concisely describes the main change: removing duplicate terminal backlog test replays. |
| Description check | |
The description is complete and focused. It explains the change, reason, testing results, scope, limitations, CI status, and checklist items. The maintainer-specific lack of a linked issue is explicit… |
✨ Finishing Touches
-
-
📝 Generate docstrings
-
-
- Commit to this branch
- Create a new PR
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
ELI5
Mobile backlog tests now check the same behavior with four fewer expensive transcript replays.
What Changed
Move the existing frame-count and frame-size assertions into the same plain and colored transcript runs that already check liveness and exact byte order. Remove four repeated runs; retain every meaningful assertion and all negative controls. Only one test file changes.
Why
Each replay processes a 5 MB transcript. Reusing its real result avoids duplicate work without changing production code, fixtures, timeouts or the test framework.
Linked Issue
N/A — maintainer testing improvement.
Visual Proof
N/A — no product UI change.
Testing
Linux ARM, Node 24.21, shipped Vitest 4.1.11; one worker, separate fresh caches, same source and settings:
All 15 retained identities and statuses match; the four removed identities are the duplicate replays. Scoped formatting and lint passed. The existing tests-typecheck ratchet passed: 966 files checked, four intentionally excluded, existing 122-file debt unchanged.
AI Disclosure
Implemented with Codex; direct Codex agents reviewed source and measurements.
Review
Independent source review passed. Exact-head ordinary CI completed 20 checks: six successful, fourteen legitimate skips; no blocking reviews or unresolved threads.
Agent skill upstream boundary
Notes
This is one ordered, focused Linux pair: 46.03% less wall time and 45.63% less CPU for this file. No whole-suite or hosted capacity claim. Normal PR CI consumed 596 assigned runner-seconds across six allocations, plus 25 queue-seconds; no failed or cancelled jobs. Measured Linux ARM only; macOS and Windows were not run. Focused tests plus formatting, lint and successful typecheck took about 29.3 s. Earlier compiler attempts cost 46.1 s: the local default heap ran out, and two disposable measurement configs needed removal. These failures are retained; no shipped typecheck settings changed.
Checklist