Skip to content

chore(relay-staging): declare staging C4 on image E so the director can deploy it - #27462

Merged
Jinwoo-H merged 1 commit into
mainfrom
relay-staging-c4-image-e
Oct 11, 2026
Merged

Jinwoo-H merged 1 commit into
mainfrom
relay-staging-c4-image-e

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​3 $\color{#cf222e}{\Huge{\mathbf{−}}}$​2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 0

ELI5

Staging's director can only be deployed with the image that staging's c4 cell is declared on. This moves that declaration to the new image, E, so the director can run the event-loop freeze metric and its alert. Nothing rolls by itself.

What Changed

  • environments/staging.tfvars: staging-gce-c4.image changes from D (sha256:ac2ab357…) to E (sha256:94bc2b2d…). E is main 2bdb55350d3, built by publish run 38125094372 and mirrored to staging by run 38125199997.
  • The C4 pin in relay-staging-c4-refresh-workflow.test.mjs follows.

Why

Deploy Relay Staging refuses any expected-image-digest other than c4's checked-in image. The director needs E for eventLoopDelayMsMax (#27405) and the stall alert (#27406).

What it does not change. The live c4 VM stays on D until its own reviewed refresh workflow runs. Until then the checked-in value is ahead of the live cell, and step5-land, who owns c4, has been told.

Linked Issue

N/A (internal staging change).

Visual Proof

N/A: configuration only.

Testing

  • The Asia/staging dev-script suites that read staging.tfvars pass.
  • terraform fmt -check passes.

AI Disclosure

N/A (internal contributor).

Agent skill upstream boundary

  • Not applicable.

Checklist

  • Small and focused
  • Explained what changed and why
  • N/A: no UI
  • Self-reviewed
  • N/A: cross-platform
  • Tests pass locally

…an deploy it

The staging director deploy binds its digest to staging-gce-c4's checked-in image. E is main
2bdb553 (#27405 event-loop max, #27406 sidecar), already mirrored to staging. C4 itself
changes only through its own reviewed refresh workflow.
@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 96e32458-42c4-450a-872d-f7487f11dfa5

📥 Commits

Reviewing files that changed from the base of the PR and between 4468a53 and 7aeb350.


📒 Files selected for processing (2)
  • cloud/dev/scripts/relay-staging-c4-refresh-workflow.test.mjs
  • cloud/infra/terraform/environments/staging.tfvars

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.



📝 Walkthrough

Walkthrough

The staging-gce-c4 Terraform configuration now uses relay image digest 94bc2b2d…dd82fc8. The staging C4 workflow test now expects that digest and updates its comments to describe image E’s event-loop maximum and director sidecar.


Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 7aeb3

The checked-in C4 target changes to E, while the live VM remains unchanged until a manual refresh explicitly supplies E. The separate recovery workflow’s pinned digest already differed from the baseline configuration, so this change does not newly disable that path.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the staging C4 image declaration change and its deployment purpose.
Description check Passed The description is complete and focused. It explains the change, reason, deployment impact, testing, visual proof, and checklist status. It references issues #27405 and #27406 in the rationale, althou…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)


  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Jinwoo-H
Jinwoo-H merged commit 265e4d4 into main Oct 11, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant