Repository navigation
refactor(runtime): remove unused text-search spawn hook - #27418
Conversation
#27396 deleted the write-only registry that consumed it; nothing sets the option now, and its doc comment implied a cancellation path that no longer exists.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This removes unused runtime search bookkeeping without removing request-abort cancellation. No actionable merge risk remains. Pre-merge checks |
|
ELI5
Removes a leftover hook that nothing uses anymore. Search behaves exactly the same.
What Changed
onTextSearchSpawnoption from the local filesystem provider and its passthrough inrequireRuntimeFileProvider.Why
#27396 deleted the write-only registry that was the hook's only producer, so nothing sets the option anymore. Its doc comment ("Registers a running text search for cancellation") implied a cancellation path that no longer exists. Request abort signals still cancel runtime searches. The renderer IPC search keeps its own by-id registry through
runBundledRipgrepTextSearch'sonSpawn, which this PR doesn't touch.Linked Issue
Follow-up to #27396.
Visual Proof
N/A — dead-code removal with no UI or behavior change.
Testing
No new tests: only unused code is removed.
pnpm tc:node, the provider/search/ripgrep suites (50 tests) and the changed-code quality gate pass.Review
Agent skill upstream boundary
Notes
Local, Windows, SSH and folder workspaces aren't affected: SSH providers never received this option, and local abort handling is unchanged.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)