Repository navigation
test(wire): give the preflight downgrade journey a non-Windows old host - #27177
Conversation
#27164 made an old host without a known non-Windows platform ask for an update instead of answering its default list. The cross-version journey mocked the capability probe but not the status read, so no request ever reached the wire.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The mock exercises the intended old-host behavior, with assertions covering the requests and results. No identified issue blocks merging. Pre-merge checks |
|
ELI5
A CI test on
mainstarted failing after #27164. This fixes the test, not the product.What Changed
#27164 changed agent detection: when a host is too old to scope detection to a workspace, the client first reads the host's status. If the host is Windows, or doesn't report its platform, the client asks the user to update the host instead of using the host's default list. The cross-version test
preflight-workspace-scoped-downgrademocked the capability check but not that new status read, so the old host looked platform-less and no request was ever sent (expected [] to deeply equal [detectAgents, refreshAgents]). The mock now returns the host's capabilities plushostPlatform: 'linux'. That matches what the journey is meant to cover: an old non-Windows host answering with its default list.Why
It is red on every PR that triggers the cross-version lane, for example #27174. The Windows "ask to update" path is already covered by
runtime-detected-agents.test.tsfrom #27164.Linked Issue
N/A, CI fix.
Visual Proof
N/A, test-only.
Testing
vitest run tests/e2e/cross-version-wire/preflight-workspace-scoped-downgrade.unit.test.ts: 4/4 pass (fails on main)Agent skill upstream boundary
Checklist