Repository navigation
fix(i18n): correct Korean Finder menu label - #26866
Merged
Merged
Conversation
Based on #26421 by @abruption. Reuse the existing Korean Finder wording and preserve it through the catalog repair table.
nwparker
marked this pull request as ready for review
October 9, 2026 11:58
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 42 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
The Korean Finder menu label now says “Finder에서 보기” (“Show in Finder”). Previously it said “Finder에 공개,” which suggests making something public.
What Changed
Use Orca's existing Korean Finder wording for the shared macOS reveal label. Add the same key to the existing Korean override table so catalog regeneration preserves the correction.
Why
This action shows an item's location in Finder. Reusing the existing approved phrase corrects the meaning and keeps menus consistent without changing their action or layout.
Linked Issue
Fixes #26420
Based on the original catalog correction in #26421 by @abruption, with independent source review and hidden macOS rendering verification. The override-table entry additionally preserves the fix when catalogs are regenerated.
Visual Proof
Before:
Finder에 공개. After:Finder에서 보기. The actual menu item retains the same 246 x 25 bounds and both labels fit without clipping. Uploaded images were downloaded and verified byte-for-byte against these actual menu captures.Testing
Actual hidden macOS Orca file-explorer context menu in Korean/dark theme, captured through Playwright CDP before and after. Native Finder was not invoked. All 26 existing platform-label/remote-guard, explorer/source-control menu, Korean semantic correction and override-table tests pass. Whole localization-catalog verification and full-file formatting checks pass; diff whitespace is clean. Native Windows (Node 24.18.0) and Linux (Node 26.8.1) also pass the same 26 cases and full catalog verification on this exact commit, with locked Vitest 5.0.3 dependencies. These are locale/platform-menu fixture checks; actual rendered UI proof is macOS only.
The existing repair function was also checked before/after with the incorrect cached translation. The scoped override now returns the approved phrase. Whole JSON comparisons confirm one catalog value changed and one Korean-only override added; Windows/Linux labels and all other catalog entries are unchanged. No executable logic or style changed, so no additional typecheck is needed.
Review
Independent final source and rendering review found no blockers. The reviewer independently compared all catalog/override leaves, checked the real repair result and inspected the actual menu captures.
Agent skill upstream boundary
Notes
The shared helper already selects separate labels for macOS, Windows and Linux. Its platform selection, local/SSH routing, remote ownership guards and reveal handlers are unchanged.
Checklist