Skip to content

fix(i18n): correct Korean Finder menu label - #26866

Merged
nwparker merged 2 commits into
mainfrom
nwparker/obvious-korean-finder-10-09
Oct 10, 2026
Merged

nwparker merged 2 commits into
mainfrom
nwparker/obvious-korean-finder-10-09

Conversation

@nwparker

@nwparker nwparker commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​4 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​3

ELI5

The Korean Finder menu label now says “Finder에서 보기” (“Show in Finder”). Previously it said “Finder에 공개,” which suggests making something public.

What Changed

Use Orca's existing Korean Finder wording for the shared macOS reveal label. Add the same key to the existing Korean override table so catalog regeneration preserves the correction.

Why

This action shows an item's location in Finder. Reusing the existing approved phrase corrects the meaning and keeps menus consistent without changing their action or layout.

Linked Issue

Fixes #26420

Based on the original catalog correction in #26421 by @abruption, with independent source review and hidden macOS rendering verification. The override-table entry additionally preserves the fix when catalogs are regenerated.

Visual Proof

Before: Finder에 공개. After: Finder에서 보기. The actual menu item retains the same 246 x 25 bounds and both labels fit without clipping. Uploaded images were downloaded and verified byte-for-byte against these actual menu captures.

Before After
Korean menu before Korean menu after

Testing

  • I manually tested these changes locally
  • Automated tests run; no new test added for the literal wording change

Actual hidden macOS Orca file-explorer context menu in Korean/dark theme, captured through Playwright CDP before and after. Native Finder was not invoked. All 26 existing platform-label/remote-guard, explorer/source-control menu, Korean semantic correction and override-table tests pass. Whole localization-catalog verification and full-file formatting checks pass; diff whitespace is clean. Native Windows (Node 24.18.0) and Linux (Node 26.8.1) also pass the same 26 cases and full catalog verification on this exact commit, with locked Vitest 5.0.3 dependencies. These are locale/platform-menu fixture checks; actual rendered UI proof is macOS only.

The existing repair function was also checked before/after with the incorrect cached translation. The scoped override now returns the approved phrase. Whole JSON comparisons confirm one catalog value changed and one Korean-only override added; Windows/Linux labels and all other catalog entries are unchanged. No executable logic or style changed, so no additional typecheck is needed.

Review

Independent final source and rendering review found no blockers. The reviewer independently compared all catalog/override leaves, checked the real repair result and inspected the actual menu captures.

Agent skill upstream boundary

  • Not applicable; no upstream skill content changed.

Notes

The shared helper already selects separate labels for macOS, Windows and Linux. Its platform selection, local/SSH routing, remote ownership guards and reveal handlers are unchanged.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • Before/after screenshots attached
  • Self-reviewed for correctness, security and performance
  • Cross-platform and SSH impact considered
  • Hosted static/typecheck, five Node 24 test shards, relay integration, Linux/Windows packaging, unit-selection evidence and aggregate checks pass. Ready-event follow-on workflows also passed on the same reviewed commit.

Based on #26421 by @abruption. Reuse the existing Korean Finder wording and preserve it through the catalog repair table.
@nwparker
nwparker marked this pull request as ready for review October 9, 2026 11:58
@nwparker
nwparker requested a review from brennanb2025 as a code owner October 9, 2026 11:58
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d8cfad93-d332-4a64-bfa7-5e384daf3836

📥 Commits

Reviewing files that changed from the base of the PR and between 4845ae8 and 9aafc79.


📒 Files selected for processing (2)
  • config/scripts/locale-ko-key-overrides.json
  • src/renderer/src/i18n/locales/ko.json


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Records the retained adapted contribution from #26421 in replacement PR #26866.

Co-authored-by: YEONGUK LEE <contact@abruption.dev>
@nwparker
nwparker merged commit f4c4eae into main Oct 10, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Korean Reveal in Finder label implies publishing

1 participant