Repository navigation
fix(agents): show DeepSeek icon for observed Build sessions - #26863
Merged
Merged
Conversation
Adapted from #25797 by @innocarpe, preserving its full renderer-only scope. Co-authored-by: Wooseong Kim <innocarpe@gmail.com>
nwparker
marked this pull request as ready for review
October 9, 2026 11:55
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 seconds. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7 of 9 tasks
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Recognized DeepSeek Build terminals currently show a generic D. They now show the existing bundled DeepSeek whale.
What Changed
AgentIcon uses the existing DeepSeek Harness image when the observed identity is
dsb. DeepSeek Build remains outside the launch catalog.Why
Reuse the project's existing brand image through the icon lookup instead of adding artwork or launch support. This implements the full scope proposed by @innocarpe in #25797; co-author credit is retained.
Linked Issue
Follow-up to closed #23484, whose recognition work already landed in #24704. Adapts #25797 by Wooseong Kim (@innocarpe), original commit
51e16d3b76685c811bfb8845270deaaab1fd78b8.Visual Proof
Before and after screenshots show the real AgentIcon/catalog in an isolated hidden Electron renderer, at its normal 14px size and enlarged for inspection. They do not show a live DSB session or the full Orca window.
Testing
The pnpm wrapper cannot reconcile this child worktree's shared node_modules symlink, so the equivalent underlying Node test/typecheck/quality scripts ran directly. CI will cover the full build and other platforms.
Review
Independent review passed with no blockers. The reviewer compared the full original contributor scope, checked the rendered image and unchanged fallback/catalog behavior, and independently passed all 13 AgentCombobox tests.
Agent skill upstream boundary
Notes
No detector, terminal screen rule, catalog entry, launch behavior or remote image request changes. The existing bundled URL works independently of SSH/folder workspace routing. Mobile uses a separate icon renderer and is outside the original two-file scope. A real DSB session and native Windows/Linux rendered UI were not exercised.
Checklist