Skip to content

fix(agents): show DeepSeek icon for observed Build sessions - #26863

Merged
nwparker merged 1 commit into
mainfrom
nwparker/obvious-dsb-icon-10-09
Oct 10, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/obvious-dsb-icon-10-09

Conversation

@nwparker

@nwparker nwparker commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​7 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​7
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​3 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​2

ELI5

Recognized DeepSeek Build terminals currently show a generic D. They now show the existing bundled DeepSeek whale.

What Changed

AgentIcon uses the existing DeepSeek Harness image when the observed identity is dsb. DeepSeek Build remains outside the launch catalog.

Why

Reuse the project's existing brand image through the icon lookup instead of adding artwork or launch support. This implements the full scope proposed by @innocarpe in #25797; co-author credit is retained.

Linked Issue

Follow-up to closed #23484, whose recognition work already landed in #24704. Adapts #25797 by Wooseong Kim (@innocarpe), original commit 51e16d3b76685c811bfb8845270deaaab1fd78b8.

Visual Proof

Before and after screenshots show the real AgentIcon/catalog in an isolated hidden Electron renderer, at its normal 14px size and enlarged for inspection. They do not show a live DSB session or the full Orca window.

Before

After

Testing

  • Rendered the real component on macOS through hidden Electron and Playwright CDP; both fixed icons decode from the local bundled image.
  • 135 focused tests pass, including icon rendering, launch exclusion and existing recognition boundaries; added icon test fails on the unchanged baseline.
  • Renderer typecheck, changed code quality/design-system gate, type-aware lint, formatting and diff checks.
  • Native Linux and Windows component/catalog portability: 23 tests each (AgentCombobox and launch-option boundaries), canonical Vitest 5.0.3 with locked own dependencies; Linux Node 26.8.1 and Windows Node 24.18.0. Actual rendered UI proof is macOS only.

The pnpm wrapper cannot reconcile this child worktree's shared node_modules symlink, so the equivalent underlying Node test/typecheck/quality scripts ran directly. CI will cover the full build and other platforms.

Review

Independent review passed with no blockers. The reviewer compared the full original contributor scope, checked the rendered image and unchanged fallback/catalog behavior, and independently passed all 13 AgentCombobox tests.

Agent skill upstream boundary

  • Not applicable: no agent skill content changed.

Notes

No detector, terminal screen rule, catalog entry, launch behavior or remote image request changes. The existing bundled URL works independently of SSH/folder workspace routing. Mobile uses a separate icon renderer and is outside the original two-file scope. A real DSB session and native Windows/Linux rendered UI were not exercised.

Checklist

  • Small and focused, with the user-facing change, mechanism and rationale explained.
  • Before/after screenshots prepared for attachment outside the code diff.
  • Self-reviewed for correctness, security and performance.
  • Cross-platform, SSH/folder and mobile boundaries considered.
  • Focused tests and applicable local checks pass; CI covers the full build.

Adapted from #25797 by @innocarpe, preserving its full renderer-only scope.

Co-authored-by: Wooseong Kim <innocarpe@gmail.com>
@nwparker
nwparker marked this pull request as ready for review October 9, 2026 11:55
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 47 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 44d32237-67a8-4ba4-bbbe-582261bb0c84

📥 Commits

Reviewing files that changed from the base of the PR and between 4845ae8 and 1999aa7.


📒 Files selected for processing (2)
  • src/renderer/src/components/agent/AgentCombobox.test.tsx
  • src/renderer/src/lib/agent-catalog.tsx


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nwparker
nwparker merged commit c22f4b0 into main Oct 10, 2026
54 checks passed
@nwparker
nwparker deleted the nwparker/obvious-dsb-icon-10-09 branch October 10, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recognize manually launched DeepSeek Build sessions in Orca

1 participant