[brennanb2025]

Summary

• add main-process hosted review IPC coverage for SSH worktree PR flows
• cover create-PR behavior for remote/default branch metadata in SSH contexts
• extend renderer hosted review store coverage for SSH-backed PR state
• fix SSH hosted-review worktree path validation so remote worktree paths are checked against remote git worktree list, not local filesystem auth
• route SSH create-PR preflight through structured relay RPCs for dirty status and upstream status instead of blocked raw git status / rev-list

Test Plan

• pnpm run typecheck
• pnpm run lint
• git diff --check
• pnpm vitest run --config config/vitest.config.ts src/main/source-control/hosted-review-creation.test.ts src/main/ipc/hosted-review.test.ts src/main/github/client-create-pr.test.ts src/main/ipc/github.test.ts src/renderer/src/store/slices/hosted-review.test.ts
  • 5 files passed, 40 tests passed

Live SSH/GitHub Validation

• Launched this exact PR worktree in Electron and verified window.api.app.getIdentity() reported:
  • branch: brennankbenson/fix-ssh-pr-workflow-main
  • root: /Users/thebr/orca/workspaces/orca/fix-ssh-pr-workflow-main
• Built the SSH relay with pnpm run build:relay.
• Started a throwaway Linux Docker SSH target using orca-ssh-test:latest.
• Created a disposable non-Orca GitHub repo: brennanb2025/orca-ssh-pr-test-20260522110743.
• Added /home/tester/demo-project from the Linux SSH target to Orca as an SSH-backed repo.
• Ran hosted-review eligibility through Orca over SSH with worktreePath: /home/tester/demo-project; result was canCreate: true.
• Ran Orca createHostedReview(...) over SSH; it created PR Linux support #1 successfully:
  • https://github.com/brennanb2025/orca-ssh-pr-test-20260522110743/pull/1
• Ran Orca window.api.gh.mergePR(...) over the same SSH-backed repo; result was { ok: true }.
• Verified GitHub reported PR Linux support #1 as MERGED at 2026-05-22T18:09:35Z.
• Verified from inside the SSH container that origin/main fetched successfully and contained feature.txt from the merged PR.
• Cleaned up local app state, SSH target, Docker container, temp files, and dev Electron session. The disposable repo was made private and archived because this token lacks delete_repo scope.

Automated Follow-up

• This PR was already merged at c886c1c35 before the automated Playwright coverage was ready.
• Follow-up PR Add Docker SSH hosted review E2E #2651 adds the opt-in Docker SSH hosted-review Playwright E2E against main:
  • Add Docker SSH hosted review E2E #2651

Merge Confidence

Merged. The live path created and merged a real pull request through Orca's SSH-backed hosted-review and GitHub merge IPC paths.