Skip to content

[CI] Fix main CI line-limit failure in protocol capability registry - #25839

Merged
nwparker merged 1 commit into
mainfrom
nwparker/fix-protocol-version-line-limit
Oct 6, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/fix-protocol-version-line-limit

Conversation

@nwparker

@nwparker nwparker commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​47 $\color{#cf222e}{\Huge{\mathbf{−}}}$​28 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​19

ELI5

Fixes a failure on main that prevents pull requests from reaching tests and packaging.

What Changed

protocol-version.ts contains 301 counted lines, exceeding the 300-line lint limit. Move the related orchestration capability declarations into orchestration-runtime-capabilities.ts, re-export the same public names, and spread their ordered list into the runtime capability registry.

Why

This follows the existing capability-module pattern and gives the registry room to grow while keeping the line-limit rule. Exported constants, protocol versions, and advertised capability ordering stay identical.

Linked Issue

CI failure observed in #25836. The failing file is identical on current main and that PR's original base.

Visual Proof

N/A — declaration relocation only; no UI or interaction changes.

Testing

  • Reproduced the exact CI lint failure locally before the fix
  • Existing compatibility tests used; no new behavior to test

Passed locally:

  • Full pnpm exec oxlint --format github: zero warnings/errors.
  • pnpm tc.
  • pnpm run check:code-quality:changed -- origin/main: zero new findings.
  • pnpm test src/shared/protocol-compat.test.ts: 14 tests passed.
  • Bundled the original and new protocol modules and compared every public export: all 115 export names/values and all 112 advertised capability entries, including ordering, are identical.

Review

Self-reviewed the module split, unchanged exports, literal tuple types, capability ordering, and absence of circular imports.

Agent skill upstream boundary

  • Not applicable; no skill source copied.

Notes

No platform behavior, host routing, wire values, protocol versions, or compatibility ranges change. Existing import paths continue to work.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • Visual proof marked N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform and SSH/remote impact considered
  • Full test suite and packaging left to CI; full lint, typecheck, and focused compatibility tests pass locally

@nwparker
nwparker merged commit 4de9f9f into main Oct 6, 2026
5 checks passed
brennanb2025 added a commit that referenced this pull request Oct 6, 2026
Brings main's max-lines fix for protocol-version.ts (#25839).
@nwparker nwparker changed the title Fix main CI line-limit failure in protocol capability registry [CI] Fix main CI line-limit failure in protocol capability registry Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant