Repository navigation
[CI] Fix main CI line-limit failure in protocol capability registry - #25839
Merged
Merged
Conversation
brennanb2025
added a commit
that referenced
this pull request
Oct 6, 2026
Brings main's max-lines fix for protocol-version.ts (#25839).
7 of 8 tasks
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Fixes a failure on main that prevents pull requests from reaching tests and packaging.
What Changed
protocol-version.tscontains 301 counted lines, exceeding the 300-line lint limit. Move the related orchestration capability declarations intoorchestration-runtime-capabilities.ts, re-export the same public names, and spread their ordered list into the runtime capability registry.Why
This follows the existing capability-module pattern and gives the registry room to grow while keeping the line-limit rule. Exported constants, protocol versions, and advertised capability ordering stay identical.
Linked Issue
CI failure observed in #25836. The failing file is identical on current main and that PR's original base.
Visual Proof
N/A — declaration relocation only; no UI or interaction changes.
Testing
Passed locally:
pnpm exec oxlint --format github: zero warnings/errors.pnpm tc.pnpm run check:code-quality:changed -- origin/main: zero new findings.pnpm test src/shared/protocol-compat.test.ts: 14 tests passed.Review
Self-reviewed the module split, unchanged exports, literal tuple types, capability ordering, and absence of circular imports.
Agent skill upstream boundary
Notes
No platform behavior, host routing, wire values, protocol versions, or compatibility ranges change. Existing import paths continue to work.
Checklist