Repository navigation
fix(test): restore the codexProviderHandle import in the submission-positions test - #25722
Merged
Merged
Conversation
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Two parallel fixes for a duplicate import both landed (#25713 and #25717), and between them they removed both copies. The test file still uses the function, so main's typecheck is red.
What Changed
Re-adds the single
import { codexProviderHandle } from '../../../shared/agent-session-provider-handle-encoding'injournal-submission-positions.test.ts, in import-order position. No other changes.Why
Smallest fix that turns main's typecheck green again (TS2304 at line 29).
Linked Issue
None — maintainer PR fixing main's typecheck, broken since #25717.
Visual Proof
N/A — test-only import, no UI or behavior change.
Testing
pnpm tcexits 0npx vitest run --config config/vitest.config.ts src/main/native-chat/agent-session-journal/journal-submission-positions.test.ts— 5/5 passoxlint and oxfmt clean on the file
I manually tested these changes locally
Automated tests added/updated, or explained why not below (fixes an existing test file)
Checklist
N/Awith reason for visuals