Skip to content

fix(test): restore the codexProviderHandle import in the submission-positions test - #25722

Merged
Jinwoo-H merged 1 commit into
mainfrom
fix/main-tc-restore-provider-import
Oct 6, 2026
Merged

Jinwoo-H merged 1 commit into
mainfrom
fix/main-tc-restore-provider-import

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1
Prod 0 0 0 0

ELI5

Two parallel fixes for a duplicate import both landed (#25713 and #25717), and between them they removed both copies. The test file still uses the function, so main's typecheck is red.

What Changed

Re-adds the single import { codexProviderHandle } from '../../../shared/agent-session-provider-handle-encoding' in journal-submission-positions.test.ts, in import-order position. No other changes.

Why

Smallest fix that turns main's typecheck green again (TS2304 at line 29).

Linked Issue

None — maintainer PR fixing main's typecheck, broken since #25717.

Visual Proof

N/A — test-only import, no UI or behavior change.

Testing

  • pnpm tc exits 0

  • npx vitest run --config config/vitest.config.ts src/main/native-chat/agent-session-journal/journal-submission-positions.test.ts — 5/5 pass

  • oxlint and oxfmt clean on the file

  • I manually tested these changes locally

  • Automated tests added/updated, or explained why not below (fixes an existing test file)

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • N/A with reason for visuals
  • Self-reviewed
  • Cross-platform / SSH impact: N/A (test import only)

@Jinwoo-H
Jinwoo-H merged commit 41f1103 into main Oct 6, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant