Repository navigation
Conversation
… never ran orcad (and Electron serve) finished a dispatched run on a satisfied tui-idle wait, and a ready shell prompt satisfies it: a run whose agent is not installed read 'completed' within seconds. Like the desktop runner, completion now needs the agent's own status for the run's pane after dispatch; without it the run fails after the agent-start window with the reason, instead of claiming completion.
Contributor
|
This run was cancelled 🛑 The workflow was cancelled before completion. Please check the link below for details. |
…l only a refused command Not every automation agent reports status on orcad (no hooks on the host, no recognised title), so requiring it would fail their runs. A run completes on the agent's own status, fails when the shell refused the agent's command (bash, zsh, dash, fish, PowerShell, cmd), and otherwise keeps the old idle-means-done rule after the agent-start window.
Merged
7 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

ELI5
On a remote Orca server, an automation whose agent wasn't installed (for example
gooseorclaudemissing on that host) was marked "completed" within about 10 seconds. The terminal only showed the command typed and "command not found". Now that run fails with the shell's own message. Agents that work keep completing as before.What Changed
Before: orcad and Electron
orca servedispatch automations headlessly. A headless run counted as completed as soon as its terminal looked idle. A plain shell prompt also counts as idle, so "goose: command not found" followed by a prompt was recorded ascompleted.After, once the terminal looks idle:
completed. That's the desktop runner's signal. Status the pane held from an earlier run doesn't count.bash: pytest: command not foundnever fails the run.How:
headless-run-completion.ts.getAgentStatusRowsForPane(paneKey), which reads the status rows the host already keeps. Both orcad and Electron wire it.Why
Linked Issue
Fixes # (Phase 3 real-host BUG-19)
Visual Proof
N/A. No UI change. The run history status and its error text change, which the tests cover.
Testing
New tests in
runtime-automation-service.test.tsdrive the real headless dispatcher against a fake runtime, where a shell prompt always looks idle:completed.command not foundline never fails the run.Against the old dispatcher, 7 of the 9 cases fail, and the missing-command cases read
completed. The automations suites pass locally (32 files, 237 tests), and typecheck and the changed-code quality gate are clean.AI Disclosure
Review
Agent skill upstream boundary
docs/reference/agent-skill-sharing-upstream-boundary.mdand copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.Notes
This applies to orcad on any host (Linux, macOS, Windows, or over SSH) and to Electron
orca serve, which shares the headless path. The desktop runner is unchanged. No wire changes.Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)