Repository navigation
Conversation
|
Important Review skippedWe couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 7.69% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 6 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request. Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request. Title check ✅ Passed The title clearly and concisely describes the main change: displaying the DeepSeek API balance in the mobile app. Description check ✅ Passed The description is complete and relevant. It explains the user-visible change, implementation scope, rationale, linked issues, testing results, limitations, and AI disclosure. It omits the template's …
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
ℹ️ Recent review info
-
⚙️ Run configuration
-
Configuration used: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 2c50ae4c-2023-40a2-aee1-50b60a94210d
📥 Commits
-
Reviewing files that changed from the base of the PR and between 15eefdf065a71b4ef93e1455823f51f4a97dc30e and 00f0dd17162caea8187f84b1b48de87fa43e90cc.
📒 Files selected for processing (2)
-
mobile/src/components/deepseek-account-usage.test.tsmobile/src/components/deepseek-account-usage.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
ℹ️ Recent review info
-
⚙️ Run configuration
-
Configuration used: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID:
2c50ae4c-2023-40a2-aee1-50b60a94210d
📥 Commits
-
Reviewing files that changed from the base of the PR and between 15eefdf065a71b4ef93e1455823f51f4a97dc30e and 00f0dd17162caea8187f84b1b48de87fa43e90cc.
📒 Files selected for processing (2)
-
mobile/src/components/deepseek-account-usage.test.tsmobile/src/components/deepseek-account-usage.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
-
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: e899305d-f7b3-44e5-943f-23ccc63f5fe9
📥 Commits
Reviewing files that changed from the base of the PR and between 46907de and a21b57d5325eeed5cd957360b379c6302b88c158.
📒 Files selected for processing (6)
mobile/app/h/[hostId]/accounts.tsxmobile/src/accounts/DeepSeekAccountUsageSection.tsxmobile/src/components/deepseek-account-usage.test.tsmobile/src/components/deepseek-account-usage.tsmobile/src/home/MobileHomeAccountUsageCards.tsxmobile/src/home/use-mobile-home-data.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- DeepSeek usage selector —
getDeepSeekAccountUsage/hasDeepSeekAccountUsagevalidate the optionalrateLimits.deepseekslot in isolation, so a malformed payload cannot take down Claude/Codex decoding, and map the host's monthly balance window toloading/available/depleted/refresh-error/unavailable. - Accounts screen — new read-only
DeepSeekAccountUsageSectionmounted after the Codex section. - Home usage card — a DeepSeek row in
MobileHomeAccountUsageCards, plus ahasDeepSeekAccountUsageclause so DeepSeek-only hosts still appear on Home. - Tests — logic coverage for each status, a malformed-slot isolation case, and a source-string seam test over the three wiring sites.
I traced the consumed contract against the still-open host PR #12873: ProviderRateLimits.provider gains 'deepseek', RateLimitState gains deepseek + deepseekAuthConfigured, the fetcher maps the USD balance into monthly.resetDescription with usedPercent 0/100, and applyStalePolicy preserves the prior window with status: 'error' on a failed refresh — which is exactly what the mobile refresh-error branch expects. The extended schema also keeps working after #12873 adds 'deepseek' to the base enum.
ℹ️ This view is inert until #12873 lands
Every field this PR reads — rateLimits.deepseek and rateLimits.deepseekAuthConfigured — comes from the still-open host PR #12873, so on its own the mobile view always returns null and stays hidden. That is safe but dark; the only thing worth settling before merge is that #12873's shape is frozen, since it is still under review and could rename the balance carrier or change the usedPercent convention this code hard-codes.
Technical details
# DeepSeek mobile view depends on an unmerged host contract
## Affected sites
- `mobile/src/components/deepseek-account-usage.ts:26` — reads `rateLimits.deepseekAuthConfigured`
- `mobile/src/components/deepseek-account-usage.ts:34` — reads `rateLimits.deepseek`
- `mobile/src/components/deepseek-account-usage.ts:52` — treats `monthly.resetDescription` as the balance label
- `mobile/src/components/deepseek-account-usage.ts:58` — treats `monthly.usedPercent >= 100` as depleted
## Required outcome
- Confirm the host PR #12873 field names and the `resetDescription`/`usedPercent` conventions are frozen, or land the two PRs together.
## Suggested approach (optional)
- No code change required here; this is a merge-ordering / contract-stability question.DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏
a21b57d to
15eefdf
Compare
 [Medium impact] The PR appears safe to merge, with a non-blocking accessibility announcement concern. Findings
SummaryThe PR displays host-supplied DeepSeek balance and status on Mobile Home and Accounts, distinguishes malformed balance data from a pending request, and adds rendered state tests. The conditional status announcement may not be heard when an unchanged balance develops an error. Reviews (3) · Last reviewed commit: "fix(mobile): show unavailable balances a..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 85a02293-2070-41c2-9c84-cff1e63c2ca4
📥 Commits
Reviewing files that changed from the base of the PR and between a21b57d5325eeed5cd957360b379c6302b88c158 and 15eefdf065a71b4ef93e1455823f51f4a97dc30e.
📒 Files selected for processing (3)
mobile/src/accounts/DeepSeekAccountUsageSection.tsxmobile/src/components/deepseek-account-usage.tsmobile/src/home/MobileHomeAccountUsageCards.tsx
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This pass re-reviewed only the delta since the prior Pullfrog review (15eefdf065 against a21b57d532; the ea4fe30988 feat commit is a rebase of already-reviewed content onto bd133058).
- Polite live regions on both DeepSeek surfaces —
accessibilityLiveRegion="polite"added to the balance/status text and the conditional error/status text in bothMobileHomeAccountUsageCardsandDeepSeekAccountUsageSection, matching the existing mobile status pattern. - Dropped the
readFieldhelper — the optional DeepSeek slot is now read by directly indexing the passthroughrateLimitsobject, removing the last assertion from the selector.
The selector tests (7 passed) and the mobile app typecheck are green against this revision.
DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏
15eefdf to
00f0dd1
Compare
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This pass re-reviewed the delta since the prior Pullfrog review (15eefdf065 → 00f0dd1716).
- Malformed DeepSeek payloads now report unavailable —
readDeepSeekLimitsreturns a distinctinvalidflag, andgetDeepSeekAccountUsagemaps a failed schema parse tounavailable("Balance unavailable") instead of the indefinite "Checking balance…" state; a genuinely absent slot still loads. - Render-level coverage for both surfaces — the source-string assertion over
MobileHomeAccountUsageCardsis replaced withreact-test-renderermounts of the real Home card and Accounts section across pending / malformed / available / depleted / refresh-error snapshots, asserting the visible balance/status andaccessibilityLiveRegion="polite"on changing labels. The remaining source assertions cover only Accounts route mounting and DeepSeek-only host inclusion.
Verified locally: 12 focused tests pass, and no changed file appears in the mobile typecheck:tests diagnostics (the remaining errors are pre-existing and unrelated).
DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏
|
Updated this follow-up at Greptile and Pullfrog have completed successfully. PR Checks, Mobile Checks, and PR test LoC currently require maintainer approval; please approve those workflow runs when reviewing this update. Device VoiceOver/TalkBack testing and the full mobile build remain unperformed. |
Store write-only API-key entries in protected execution-host storage and poll the documented balance endpoint through the existing account usage service. Display each currency's exact monetary strings in Accounts and the status bar, with explicit unsupported hosts and stale errors. Builds on the DeepSeek balance and mobile account work in #12873 and #23294. Co-authored-by: Wooseong Kim <innocarpe@gmail.com>
00f0dd1 to
2798978
Compare
2798978 to
4035ee9
Compare
| {deepSeekUsage.balanceLabel && deepSeekUsage.status !== 'available' ? ( | ||
| <Text | ||
| accessibilityLiveRegion="polite" | ||
| style={styles.providerStatus} | ||
| numberOfLines={1} | ||
| > | ||
| {deepSeekUsage.statusLabel} | ||
| </Text> | ||
| ) : null} |
There was a problem hiding this comment.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
4035ee9 to
43f30c8
Compare
43f30c8 to
cde988d
Compare
Sync update (
|
ELI5
Mobile Home and Accounts show the DeepSeek balance supplied by the connected host. Balance and status updates use polite live regions. Malformed balance data now shows “Balance unavailable” instead of remaining on “Checking balance…”.
What Changed
Why
The host provider work is separate in #12873. This PR presents that data on mobile and exposes changes to accessibility services without changing layout or data ownership.
Linked Issue
Refs #12869; host provider dependency #12873.
Visual Proof
N/A for this follow-up — status labels and accessibility metadata, covered by component render tests. Device screen-reader behavior was not manually tested.
Testing
AI Disclosure
Implementation and verification assisted by OpenAI Codex.
Agent skill upstream boundary
Checklist