Repository navigation
feat(mobile): one build-time switch picks native or OTA, default native (OTA phase E1) - #22193
Merged
Merged
Conversation
…native EXPO_PUBLIC_MOBILE_SHELL is read in exactly one place, mobileShellBuildKind in preferences.ts. Expo's babel preset inlines a literal process.env member expression at build time, so a release bundle carries the answer as a constant and anything but the exact string 'ota' — unset, empty, a typo — is native. Every default build is therefore the native app, unchanged. mobileWebShellFlagCanBeOn now answers __DEV__ or an OTA build, so the ability to mount the page comes from the build and never from storage: a native binary installed over an OTA one, same bundle id and same data container, still refuses a stored 'true' without reading the key. An unset key reads on only in an OTA build; a development build keeps its opt-in, and a stored 'false' wins everywhere so the Troubleshoot toggle can switch an OTA build back to native. That toggle now mounts wherever the flag can be on, which is the only way back to the native screens in an OTA build, and its label names the build kind rather than saying "(dev)". The bundle probe row beside it stays development-only: it fetches. The flag census gains two rules — one module reads the switch, in the member form Expo inlines and not the bracket form, and one named function answers the build kind — and the build-kind fence now lists the Troubleshoot route that asks it. Docblocks that said a store build can never mount the shell now say it mounts only when built for OTA. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
…tive Both release workflows gain a `shell` workflow_dispatch choice, options native and ota, default native, and hand it to the step that bundles the JavaScript as EXPO_PUBLIC_MOBILE_SHELL. That is the Gradle assembleRelease step on Android and the fastlane build_and_upload step on iOS; nothing else in either file sets it. A tag push and a schedule carry no inputs at all, so `inputs.shell || 'native'` yields native for them — the first OTA release is a dispatch with one field changed, and every other run is the app we ship today. Each build step prints the value it is about to build with, read back from the same variable rather than from a second copy of the expression, so a run's log cannot claim a shell the build did not use. The new contract test evaluates that expression rather than matching its text: absent, empty and 'native' all resolve to native, 'ota' to ota, and any expression shape it cannot evaluate is a failure rather than a pass. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
…ired build:mobile-web now runs the app builder and app verifier, and both take their output root from MOBILE_WEB_BUNDLE_DIR in the packaging guard rather than each carrying a constant of their own — one definition of where the bundle lives, so a drift cannot leave electron-builder's beforePack looking at an empty directory while the builder reports a tree it wrote elsewhere. build:mobile-web:app is gone; it was the same two commands. src/mobile-web/ and its two scripts go with it. What the app builder shared with them is split into three modules named for what they hold rather than for the bundle that used to own them: mobile-web-bundle-manifest.mjs (content types, the canonical asset serialization, buildId, hashed assets, the protocol window and the manifest write), script-entry-detection.mjs (isDirectInvocation, whose two failure modes are Windows paths and symlinked entries), and mobile-web-source-line-endings.mjs (the CRLF guard, now with a required directory rather than a default pointing at the deleted tree). The two suites that only needed *a* valid tree on disk — the beforePack guard and the packaged-bundle guard — build one from mobile-web-bundle-fixture-tree instead of bundling the whole mobile graph. It goes through the same manifest writer the page does, so a manifest shape change still reaches them. Also retired: the placeholder's tsconfig project and its typecheck lane, its knip entry, its electron-builder exclusion and .gitattributes pins, and the app-bundle test that asserted the shims stayed out of a builder that no longer exists. pr.yml's page job builds the same bundle the package job ships. Inert for native phones: they never fetch it. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
…suite The changed-code quality gate's focused plugins read the two as a duplicate import; the readFile line was left over from the split. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
The web entry said it was built by `build:mobile-web:app` into out/mobile-web-app and shipped by nothing. That script, that directory and that fact are all gone: it is built by `build:mobile-web` into the packaged bundle dir, and a phone mounts it only when the binary was built with EXPO_PUBLIC_MOBILE_SHELL=ota. Two Windows cache keys explained themselves by naming src/mobile-web and "the two bundle builders"; config/** now covers the builder, the verifier and the manifest writer, and the spike's key no longer waits on a Phase C flip that has happened. The keys themselves are unchanged. Three scratch directories in the app-bundle suites and one in the verifier still spelled the retired output root. Renamed to mobile-web, which is what the build writes; they are temp subdirectory names and nothing reads them. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
…itch # Conflicts: # config/scripts/build-mobile-web-app-bundle.test.mjs
Contributor
|
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (45)
💤 Files with no reviewable changes (9)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe mobile web build now produces the packaged page bundle through a shared manifest writer and verifier. The previous bootstrap page, builder, verifier, and mobile-web TypeScript project were removed. Source line endings and direct script invocation use dedicated helpers. Android and iOS release workflows now select Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to Release builds remain native by default, while explicitly selected OTA builds use the packaged mobile page; the current change has no evidenced merge-blocking risk. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description explains the implementation and intended behavior, but it does not follow the required template. It omits the required Linked Issue, Visual Proof, Testing, AI Disclosure, Review, Agent skill upstream boundary, Notes, and Checklist sections. Resolution Add all required template sections. Include the linked issue number, visual proof or an explicit N/A with a reason, testing steps and platform coverage, AI disclosure, review details, the agent skill boundary checkbox, notes on compatibility and security, and the checklist responses. Full details: Docstring CoverageExplanation Docstring coverage is 45.45% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 33 functions across 29 files. (7 skipped: 7 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One build-time constant decides whether a mobile binary mounts the native screens or the web page delivered over the air, and every default build is native. This is the switch the OTA programme (phases A–D, all landed inert) was waiting on; nothing ships differently until a release is dispatched with
shell=ota.Phone.
mobileShellBuildKind()inmobile/src/storage/preferences.tsis the only placeprocess.env.EXPO_PUBLIC_MOBILE_SHELLis spelled.babel-preset-expoinlines a literalEXPO_PUBLIC_*member expression at bundle time, so a release bundle carries the value, not the variable (proved on four production Metro exports: the function body reads'ota'or'native', andprocess.env.EXPO_PUBLIC_MOBILE_SHELLoccurs zero times in either bundle or its Hermes bytecode). Anything but the exact stringotais native.mobileWebShellFlagCanBeOn()becomes__DEV__ || kind === 'ota'; an unset stored key reads ON only in an OTA build, a stored'false'still wins, and the ability never comes from storage. Troubleshoot mounts the shell row wherever the flag can be on (in an OTA build it is the only way back to the native screens), labelled by build kind; the bundle probe row stays development-only. The flag census gains two rules:process.env.EXPO_PUBLIC_resolves to exactly the one file, andmobileShellBuildKindto its two callers.Release workflows.
mobile-android-release.ymlandmobile-ios-release.ymlgain aworkflow_dispatchinputshell(nativedefault,ota), and passEXPO_PUBLIC_MOBILE_SHELL: ${{ inputs.shell || 'native' }}to the step that bundles the JavaScript, printing it first. Tag pushes and schedules carry no inputs and read native. A contract test evaluates the expression rather than matching its text: absent, empty andnativeresolve to native;otato ota; an unparseable shape fails (mutated the fallback to'ota'and watched it go red).Desktop.
build:mobile-webnow builds and verifies the real page into the packaged bundle dir, whose one definition isMOBILE_WEB_BUNDLE_DIRin the packaging guard. The Phase A placeholder (src/mobile-web/, its builder, verifier, tsconfig, knip and electron-builder entries) is retired; its manifest writer, entry detection and line-ending check are split into named modules the app builder already used. Packaged reading: 110 assets, 8 routes, 8,055,568 B of the 9,437,184 B budget, reproducible buildId. The desktop readsout/mobile-webbeside the app exactly as before, so a paired phone in an OTA build fetches the real page from any desktop carrying this change, and a native phone never asks.Inert by default. No release is affected until someone runs a release workflow with
shell=ota. Native screens stay until after the first OTA release.