Skip to content

test(antigravity): verify Windows hook payload delivery through launcher - #21666

Merged
nwparker merged 1 commit into
nwparker/agy-worker-aliasfrom
nwparker/agy-windows-hook-verification
Sep 21, 2026
Merged

nwparker merged 1 commit into
nwparker/agy-worker-aliasfrom
nwparker/agy-windows-hook-verification

Conversation

@nwparker

@nwparker nwparker commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​35 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​34
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​2 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​2

ELI5

A hook can start successfully and still lose the message it was supposed to deliver. These tests check the actual message reaching Orca from Antigravity's Windows hook scripts.

What Changed

Extend the existing Windows payload-delivery suite with Antigravity PreToolUse for ordinary profile paths and paths containing spaces. The latter exercises the encoded PowerShell fallback. Both require the entire Unicode payload to arrive unchanged at a local listener and the hook to return exactly {"decision":"ask"} without extra output. The existing Windows CI step already executes this suite; it now explicitly sets ORCA_BACKGROUND_LAUNCH=1.

Why

PR #19272 proposes removing an execution-policy command from batch hook launchers but has no Windows process evidence. Existing Antigravity tests invoke wrappers directly, bypassing the encoded launcher. Reusing the delivery harness tests the real process chain instead of merely comparing generated strings. This draft starts with the existing launcher so CI can establish a baseline before any production change.

Linked Issue

Refs #17672, #19829; verification follow-up for #19272. No status or lifecycle issue is claimed fixed. Stacked on #21664.

Visual Proof

N/A — automated process-delivery tests only; no product UI change. Windows CI’s test step passed with the unchanged launcher; no successful Antigravity generation is claimed.

Testing

  • I manually tested these changes locally on Windows
  • Automated tests added

macOS collection passed: one platform-independent check passed, three Windows execution cases skipped. Node typecheck, changed-code quality and staged lint/format checks pass. Windows package job 105895776713 completed successfully. Its log confirms all four delivery-suite tests passed, including Antigravity ordinary path (488 ms) and path with spaces (780 ms). The full Windows boundary step passed 477 tests, with 22 skipped. Both new cases ran; neither was skipped. These launch actual managed scripts with synthetic hook JSON; they do not run the agy binary on Windows or validate antivirus behavior, live hooks or sidebar transitions.

Review

No production launcher change yet. Temporary hook install and loopback listener use the existing isolated test harness. No global authentication or hook settings are changed.

Agent skill upstream boundary

  • Not applicable; no upstream skill content copied.

Checklist

  • Small, focused verification change
  • Explained behavior, mechanism and approach
  • Visual proof is N/A for this test-only change
  • Self-reviewed
  • Windows execution boundary considered
  • Windows CI proves payload and permission response delivery

@nwparker

Copy link
Copy Markdown
Contributor Author

Independent verification (2026-09-20):

  • Focused local hook suites: 9 passed, 3 platform-specific Windows cases skipped on macOS.
  • PR Windows CI run 35442525038 reports 477 passed / 22 skipped; both new Antigravity delivery cases ran (ordinary and spaced paths), plus Windows packaging and all required checks passed.
  • The test invokes the real managed launcher and validates Unicode payload preservation and the exact {"decision":"ask"} response. It does not claim live agy generation or antivirus behavior.

Verdict: approve the test-only change for the Windows hook-delivery contract. Keeping it draft is reasonable if the author wants to pair it with a production launcher fix; no merge performed.

@nwparker

Copy link
Copy Markdown
Contributor Author

ELI5 / evidence / trade-offs audit

ELI5: On Windows, hook data reaches the launcher even when paths contain spaces or Unicode characters.

Proof: Windows CI passed 477 tests with both new payload cases; visual proof is not applicable to this test-contract change.

User-facing trade-off: This proves payload delivery, not every downstream hook implementation.

This note scopes the claim to the evidence above; it does not claim untested remote, SSH, WSL, or vendor combinations.

@nwparker

Copy link
Copy Markdown
Contributor Author

Native Windows verification update (2026-09-20)

Fetched PR head 2019a7494c into a disposable awin worktree and ran the exact focused file under Windows Node with ORCA_BACKGROUND_LAUNCH=1: 4/4 tests passed in 2.30s. Both new cases ran (ordinary profile path and a path containing spaces), plus the existing Git Bash/cmd delivery case.

This is the best low-risk shape for this PR: it changes tests and CI environment setup only, leaves the production launcher unchanged, and exercises the real cmd.exe/wrapper/listener chain. It does not claim live agy generation or antivirus behavior.

Verdict: low risk; approve as a test-contract PR.

@nwparker
nwparker marked this pull request as ready for review September 21, 2026 00:25
@pullfrog

pullfrog Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

This run was cancelled 🛑

The workflow was cancelled before completion. Please check the link below for details.

Pullfrog  | View workflow run | via Pullfrog | 𝕏

@nwparker
nwparker merged commit 40870a3 into nwparker/agy-worker-alias Sep 21, 2026
33 of 34 checks passed
nwparker added a commit that referenced this pull request Sep 21, 2026
* fix(cli): accept agy alias for supervised worker starts

* test(antigravity): exercise Windows hook payload delivery in CI (#21666)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant