Repository navigation
test(shared): drop the duplicated separator-only git grep test - #21116
Conversation
55ae3b3 pasted the same test twice under one title; the code-quality lint denies duplicate titles, so every PR's static-analysis job has been red since. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe pull request removes the Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The test cleanup retains coverage that prevents separator-only patterns from broadening a search to the repository, so no merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the duplicate test, the Oxlint failure, the resulting change, and the local verification. It does not follow the required template and omits the required linked issue, Visual Proof N/A statement, checklist status, and several review sections. Resolution Add the required template sections. Include a valid issue reference under Linked Issue, write N/A with a reason under Visual Proof, document the testing and platform scope, complete the Review, Agent skill upstream boundary, Notes, and Checklist sections, and state any non-applicable items explicitly.
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Remove duplicated separator-only git grep test — deletes the second byte-identical copy of
does not broaden a separator-only include pattern to the repositoryfromsrc/shared/text-search.test.ts; the surviving copy at line 354 matches the removed block exactly, and only one copy of the title and itsbuildGitGrepArgs('needle', { includePattern: '/' })call remain, so the focused code-quality lint's duplicate-title warning is cleared with no coverage lost.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
…yai#21116) 55ae3b3 pasted the same test twice under one title; the code-quality lint denies duplicate titles, so every PR's static-analysis job has been red since. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb

Commit 55ae3b3 (pushed directly to main) added the test
does not broaden a separator-only include pattern to the repositorytwice, byte-identical. The focused code-quality lint (oxlint --config config/oxlint-code-quality-native-plugins.json --deny-warnings) flags the duplicate title, so thestatic analysisjob has failed on every PR since (first seen on #21089's merge ref).This deletes the second copy. Verified locally with the same lint invocation (0 warnings) and
vitest run src/shared/text-search.test.ts(45 passed).