Skip to content

test(shared): drop the duplicated separator-only git grep test - #21116

Merged
Jinwoo-H merged 1 commit into
mainfrom
fix-text-search-duplicate-test-title
Sep 17, 2026
Merged

Jinwoo-H merged 1 commit into
mainfrom
fix-text-search-duplicate-test-title

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 0 $\color{#cf222e}{\Huge{\mathbf{−}}}$​17 $\color{#cf222e}{\Huge{\mathbf{−}}}$​17
Prod 0 0 0 0

Commit 55ae3b3 (pushed directly to main) added the test does not broaden a separator-only include pattern to the repository twice, byte-identical. The focused code-quality lint (oxlint --config config/oxlint-code-quality-native-plugins.json --deny-warnings) flags the duplicate title, so the static analysis job has failed on every PR since (first seen on #21089's merge ref).

This deletes the second copy. Verified locally with the same lint invocation (0 warnings) and vitest run src/shared/text-search.test.ts (45 passed).

55ae3b3 pasted the same test twice under one title; the code-quality lint denies duplicate titles, so every PR's static-analysis job has been red since.

Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 58cc428b-6176-4151-9625-151bfe789269

📥 Commits

Reviewing files that changed from the base of the PR and between aad41b1 and 73313a2.

📒 Files selected for processing (1)
  • src/shared/text-search.test.ts
💤 Files with no reviewable changes (1)
  • src/shared/text-search.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The pull request removes the ingestGitGrepLine integration test for the separator-only include pattern /. The deleted test created a temporary Git repository, ran git with buildGitGrepArgs, and expected the command to throw. No replacement test was added.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 73313

The test cleanup retains coverage that prevents separator-only patterns from broadening a search to the repository, so no merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the duplicate test, the Oxlint failure, the resulting change, and the local verification. It does not follow the required template and omits the required linked issue, Visual … Add the required template sections. Include a valid issue reference under Linked Issue, write N/A with a reason under Visual Proof, document the testing and platform scope, complete the Review, Agent skill upstream boundary, Notes, and Chec…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the removal of a duplicated separator-only git-grep test. It is concise and accurately describes the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the duplicate test, the Oxlint failure, the resulting change, and the local verification. It does not follow the required template and omits the required linked issue, Visual Proof N/A statement, checklist status, and several review sections.

Resolution

Add the required template sections. Include a valid issue reference under Linked Issue, write N/A with a reason under Visual Proof, document the testing and platform scope, complete the Review, Agent skill upstream boundary, Notes, and Checklist sections, and state any non-applicable items explicitly.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Remove duplicated separator-only git grep test — deletes the second byte-identical copy of does not broaden a separator-only include pattern to the repository from src/shared/text-search.test.ts; the surviving copy at line 354 matches the removed block exactly, and only one copy of the title and its buildGitGrepArgs('needle', { includePattern: '/' }) call remain, so the focused code-quality lint's duplicate-title warning is cleared with no coverage lost.

Pullfrog  | View workflow run | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

@Jinwoo-H
Jinwoo-H merged commit de4dab9 into main Sep 17, 2026
28 checks passed
@Jinwoo-H
Jinwoo-H deleted the fix-text-search-duplicate-test-title branch September 17, 2026 00:39
ivanvykopal pushed a commit to ivanvykopal/orca that referenced this pull request Sep 20, 2026
…yai#21116)

55ae3b3 pasted the same test twice under one title; the code-quality lint denies duplicate titles, so every PR's static-analysis job has been red since.

Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant