Repository navigation
test: keep artifact share fixtures unexpired across calendar dates - #18955
Conversation
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Dynamic fixture expiry —
createResponseBody/createResponsein the three artifact test files now computeexpiresAtas 30 days fromDate.now()instead of a fixed2026-09-06timestamp, keeping stored share mappings from being pruned as "expired" when the calendar rolls past that date.
The change is a clean, minimal test-only deflake. The fixed expiresAt crossed the prune threshold (Date.parse(record.expiresAt) > now in artifact-share-record-store.ts) at midnight UTC on 2026-09-06, so reuse and race tests lost their share mappings before reaching the behavior under test. Default parameters are evaluated lazily per call, so each fixture gets a fresh expiry and the fake-clock test at artifact-cloud-service.test.ts:454 is unaffected (it passes fixed dates explicitly). createdAt/updatedAt remain hardcoded but are not part of the prune path.
DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughUpdated three artifact cloud test fixtures to calculate Merge Risk: ⚪ Minimal · up to Artifact test fixtures now keep ordinary share responses valid for 30 days from creation, preventing calendar-date expiration from invalidating reuse, race, and recovery scenarios. No current merge-readiness risk remains. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description explains the fixture expiry problem, the 30-day solution, the retained fixed-date test, and the validation results. It omits most required template sections, including the linked issue, explicit ELI5, visual proof or N/A statement, testing checklist details, review notes, boundary confirmation, and repository checklist items. Resolution Add the required template sections and complete the missing information. Include an issue reference in the form
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…18967) * Stop obsolete worktree preparations when evicted or expired * Let worktree preparation proceed during stale reclamation * Verify creation during stalled stale worktree reclamation * Preserve preparation ownership until Git removal starts * test: keep artifact share fixtures unexpired across calendar dates (#18955)
* Stop obsolete worktree preparations when evicted or expired * Let worktree preparation proceed during stale reclamation * Verify creation during stalled stale worktree reclamation * Preserve preparation ownership until Git removal starts * test: keep artifact share fixtures unexpired across calendar dates (#18955) * perf(worktree): overlap base refresh with prepared checkout
…tablyai#18967) * Stop obsolete worktree preparations when evicted or expired * Let worktree preparation proceed during stale reclamation * Verify creation during stalled stale worktree reclamation * Preserve preparation ownership until Git removal starts * test: keep artifact share fixtures unexpired across calendar dates (stablyai#18955)
…#18998) * Stop obsolete worktree preparations when evicted or expired * Let worktree preparation proceed during stale reclamation * Verify creation during stalled stale worktree reclamation * Preserve preparation ownership until Git removal starts * test: keep artifact share fixtures unexpired across calendar dates (stablyai#18955) * perf(worktree): overlap base refresh with prepared checkout

Artifact service fixtures expired at midnight UTC on September 6, 2026. Reuse and race tests then lost their stored share mappings before reaching the behavior they exercise. Give ordinary response fixtures an expiry 30 days after creation; the explicit fake-clock expiry test keeps its fixed dates.
Validation: reproduced 11 failures across the three affected files; all 64 artifact tests now pass. oxfmt and oxlint passed. Test-only change.