Skip to content

test: keep artifact share fixtures unexpired across calendar dates - #18955

Merged
nwparker merged 1 commit into
mainfrom
nwparker/deflake-artifact-fixture-expiry
Sep 6, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/deflake-artifact-fixture-expiry

Conversation

@nwparker

@nwparker nwparker commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 3 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​6 $\color{#cf222e}{\Huge{\mathbf{−}}}$​3 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​3
Prod 0 0 0 0

Artifact service fixtures expired at midnight UTC on September 6, 2026. Reuse and race tests then lost their stored share mappings before reaching the behavior they exercise. Give ordinary response fixtures an expiry 30 days after creation; the explicit fake-clock expiry test keeps its fixed dates.

Validation: reproduced 11 failures across the three affected files; all 64 artifact tests now pass. oxfmt and oxlint passed. Test-only change.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Dynamic fixture expiry — createResponseBody/createResponse in the three artifact test files now compute expiresAt as 30 days from Date.now() instead of a fixed 2026-09-06 timestamp, keeping stored share mappings from being pruned as "expired" when the calendar rolls past that date.

The change is a clean, minimal test-only deflake. The fixed expiresAt crossed the prune threshold (Date.parse(record.expiresAt) > now in artifact-share-record-store.ts) at midnight UTC on 2026-09-06, so reuse and race tests lost their share mappings before reaching the behavior under test. Default parameters are evaluated lazily per call, so each fixture gets a fresh expiry and the fake-clock test at artifact-cloud-service.test.ts:454 is unaffected (it passes fixed dates explicitly). createdAt/updatedAt remain hardcoded but are not part of the prune path.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) | 𝕏

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 2f117ed8-4dd6-4353-afcf-ffdcb5db157c

📥 Commits

Reviewing files that changed from the base of the PR and between 7bb54cc and 8104211.

📒 Files selected for processing (3)
  • src/main/artifacts/artifact-cloud-recovery.test.ts
  • src/main/artifacts/artifact-cloud-service-races.test.ts
  • src/main/artifacts/artifact-cloud-service.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Updated three artifact cloud test fixtures to calculate expiresAt as 30 days from the current time. The fixtures now generate ISO timestamps instead of using a fixed date.

Merge Risk: ⚪ Minimal · up to 81042

Artifact test fixtures now keep ordinary share responses valid for 30 days from creation, preventing calendar-date expiration from invalidating reuse, race, and recovery scenarios. No current merge-readiness risk remains.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the fixture expiry problem, the 30-day solution, the retained fixed-date test, and the validation results. It omits most required template sections, including the linked issue… Add the required template sections and complete the missing information. Include an issue reference in the form Fixes #..., an ELI5 explanation, explicit What Changed and Why sections, N/A with a reason for Visual Proof, testing steps a…
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: keeping artifact share test fixtures unexpired across calendar dates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the fixture expiry problem, the 30-day solution, the retained fixed-date test, and the validation results. It omits most required template sections, including the linked issue, explicit ELI5, visual proof or N/A statement, testing checklist details, review notes, boundary confirmation, and repository checklist items.

Resolution

Add the required template sections and complete the missing information. Include an issue reference in the form Fixes #..., an ELI5 explanation, explicit What Changed and Why sections, N/A with a reason for Visual Proof, testing steps and platforms, AI disclosure when applicable, Review and Notes content, the Agent skill upstream boundary checkbox, and the applicable Checklist items.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nwparker
nwparker merged commit 71f2c5d into main Sep 6, 2026
28 checks passed
nwparker added a commit that referenced this pull request Sep 6, 2026
…18967)

* Stop obsolete worktree preparations when evicted or expired

* Let worktree preparation proceed during stale reclamation

* Verify creation during stalled stale worktree reclamation

* Preserve preparation ownership until Git removal starts

* test: keep artifact share fixtures unexpired across calendar dates (#18955)
nwparker added a commit that referenced this pull request Sep 6, 2026
* Stop obsolete worktree preparations when evicted or expired

* Let worktree preparation proceed during stale reclamation

* Verify creation during stalled stale worktree reclamation

* Preserve preparation ownership until Git removal starts

* test: keep artifact share fixtures unexpired across calendar dates (#18955)

* perf(worktree): overlap base refresh with prepared checkout
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
…tablyai#18967)

* Stop obsolete worktree preparations when evicted or expired

* Let worktree preparation proceed during stale reclamation

* Verify creation during stalled stale worktree reclamation

* Preserve preparation ownership until Git removal starts

* test: keep artifact share fixtures unexpired across calendar dates (stablyai#18955)
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
…#18998)

* Stop obsolete worktree preparations when evicted or expired

* Let worktree preparation proceed during stale reclamation

* Verify creation during stalled stale worktree reclamation

* Preserve preparation ownership until Git removal starts

* test: keep artifact share fixtures unexpired across calendar dates (stablyai#18955)

* perf(worktree): overlap base refresh with prepared checkout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant