Repository navigation
feat(cli): report SSH host platforms - #18896
Conversation
|
Warning Review limit reachedNext included review available in 3 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
ℹ️ No critical issues — two minor suggestions inline.
Reviewed changes
Reviewed the full 9-file diff that reports detected SSH host platforms through ssh.listTargetSummaries and orca host list.
- Platform on the wire —
SshTargetSummarygains an optionalremotePlatform, populated fromgetRegisteredSshState(id)?.remotePlatform(the same public-state path the renderer uses) and omitted when unknown. - CLI surface —
host listemits aplatformfield for the local machine (process.platform) and connected SSH targets, and renders it (orplatform unknown) in human output. - Tests & docs — new RPC test pins
win32propagation and absence-before-detection; the CLI routing test pins the field; docs and command specs updated.
The approach is sound: it reuses the canonical remotePlatform source already read by orca-runtime-resolve-authoritative-terminal-wait-permission.ts, the wire change is an optional additive field (safe for mixed-version pairs), and the CLI already tolerates hosts that omit it.
DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
| .map((host) => `${kindLabel[host.kind].padEnd(11)} ${host.name} -> ${host.selector}`) | ||
| .map( | ||
| (host) => | ||
| `${kindLabel[host.kind].padEnd(11)} ${host.name} ${host.platform ?? 'platform unknown'} -> ${host.selector}` |
There was a problem hiding this comment.
Paired-server rows (kind: 'environment') never carry a platform, so this now renders platform unknown for every Orca server listed. If that's intended (the paired server's platform isn't known locally), consider omitting the platform segment for environment rows rather than showing a column that can never be populated for that kind.
| export type SshTargetSummary = { | ||
| id: string | ||
| label: string | ||
| remotePlatform?: 'linux' | 'darwin' | 'win32' |
There was a problem hiding this comment.
The inline 'linux' | 'darwin' | 'win32' duplicates SshRemotePlatform from shared/ssh-types.ts. Importing the shared type keeps this CLI-local copy from drifting when the platform set changes.
* feat(cli): report SSH host platforms * feat(cli): include SSH connection status * fix(cli): preserve unknown SSH connection state

Summary
orca host list --jsonand human-readable outputVerification
pnpm test src/main/runtime/rpc/methods/ssh.test.ts src/cli/index-local-command-routing-flags.test.ts src/cli/host-selector-alternatives.test.tspnpm tc:clipnpm run check:code-quality:changed