Skip to content

feat(cli): report SSH host platforms - #18896

Merged
nwparker merged 3 commits into
stablyai:mainfrom
nwparker:nwparker/orca-cli-list-remotes
Sep 5, 2026
Merged

nwparker merged 3 commits into
stablyai:mainfrom
nwparker:nwparker/orca-cli-list-remotes

Conversation

@nwparker

@nwparker nwparker commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expose the detected SSH host platform through the existing redacted target summary RPC
  • include platform metadata in orca host list --json and human-readable output
  • keep unknown platforms explicit and preserve mixed-version compatibility
  • document the new host-list metadata

Verification

  • pnpm test src/main/runtime/rpc/methods/ssh.test.ts src/cli/index-local-command-routing-flags.test.ts src/cli/host-selector-alternatives.test.ts
  • pnpm tc:cli
  • pnpm run check:code-quality:changed
  • pre-commit lint/format hooks

@coderabbitai

coderabbitai Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 8be62301-7f99-4238-a38f-5122342b3d31

📥 Commits

Reviewing files that changed from the base of the PR and between dce5ebd and fa5d21b.

📒 Files selected for processing (10)
  • docs/site/content/docs/cli/reference.mdx
  • src/cli/format.ts
  • src/cli/handlers/environment.ts
  • src/cli/host-selector-alternatives.test.ts
  • src/cli/host-selector-alternatives.ts
  • src/cli/index-local-command-routing-flags.test.ts
  • src/cli/specs/environment.ts
  • src/main/runtime/rpc/methods/ssh.test.ts
  • src/main/runtime/rpc/methods/ssh.ts
  • src/shared/ssh-types.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — two minor suggestions inline.

Reviewed changes

Reviewed the full 9-file diff that reports detected SSH host platforms through ssh.listTargetSummaries and orca host list.

  • Platform on the wire — SshTargetSummary gains an optional remotePlatform, populated from getRegisteredSshState(id)?.remotePlatform (the same public-state path the renderer uses) and omitted when unknown.
  • CLI surface — host list emits a platform field for the local machine (process.platform) and connected SSH targets, and renders it (or platform unknown) in human output.
  • Tests & docs — new RPC test pins win32 propagation and absence-before-detection; the CLI routing test pins the field; docs and command specs updated.

The approach is sound: it reuses the canonical remotePlatform source already read by orca-runtime-resolve-authoritative-terminal-wait-permission.ts, the wire change is an optional additive field (safe for mixed-version pairs), and the CLI already tolerates hosts that omit it.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) | 𝕏

Comment thread src/cli/format.ts Outdated
.map((host) => `${kindLabel[host.kind].padEnd(11)} ${host.name} -> ${host.selector}`)
.map(
(host) =>
`${kindLabel[host.kind].padEnd(11)} ${host.name} ${host.platform ?? 'platform unknown'} -> ${host.selector}`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired-server rows (kind: 'environment') never carry a platform, so this now renders platform unknown for every Orca server listed. If that's intended (the paired server's platform isn't known locally), consider omitting the platform segment for environment rows rather than showing a column that can never be populated for that kind.

export type SshTargetSummary = {
id: string
label: string
remotePlatform?: 'linux' | 'darwin' | 'win32'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline 'linux' | 'darwin' | 'win32' duplicates SshRemotePlatform from shared/ssh-types.ts. Importing the shared type keeps this CLI-local copy from drifting when the platform set changes.

@nwparker
nwparker merged commit 51eed5a into stablyai:main Sep 5, 2026
9 of 10 checks passed
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
* feat(cli): report SSH host platforms

* feat(cli): include SSH connection status

* fix(cli): preserve unknown SSH connection state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant