Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughRuntime terminal summaries now derive titles, worktree paths, output timestamps, and previews from leaf, PTY, and mobile terminal-tab data. Runtime status fields use these derived values. A regression test covers restored mirrored terminals when the local repository is absent. The test verifies local-only host scope and preservation of the runtime host ID, worktree path, restored title, and output preview. Merge Risk: ⚪ Minimal · up to Mirrored terminals without locally registered repositories now retain titles, worktree paths, and output previews while continuing to report non-authoritative host scope correctly. No current merge-readiness risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
ℹ️ No critical issues — one minor suggestion inline.
Reviewed changes
- Metadata fallback in
buildTerminalSummary— title now falls back through the PTY record (getLatestPtyTitle/controllerTitle) and the mirrored mobile-session terminal snapshot, worktree path falls back to the parsed worktree id, andlastOutputAt/previewblend leaf and PTY values. - Regression test —
keeps mirrored paired-runtime terminal metadata when the local profile lacks that repocovers the blank-title/path/preview failure with exact value assertions, so it fails on regression rather than passing on a loose shape.
DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
| (pty ? (getLatestPtyTitle(pty) ?? pty.controllerTitle) : null) ?? | ||
| mobileTerminalTab?.title ?? | ||
| null | ||
| const parsedWorktree = parseRuntimeWorktreeId(leaf.worktreeId) |
There was a problem hiding this comment.
parseRuntimeWorktreeId preserves the folder-workspace instance suffix (it uses splitWorktreeId, not splitWorktreeIdForFilesystem). A mirrored remote terminal whose worktree id embeds ::workspace:<uuid> would surface /folder::workspace:<uuid> as its display path instead of /folder. Use splitWorktreeIdForFilesystem (or getWorktreePathBasenameFromId) for the display fallback so it matches how buildResolvedWorktreeFromId derives real paths.
|
Closing after an adversarial maintainer review. The desired outcome is reasonable, but this patch does not establish or safely fix the production failure. Blocking findings:
#18619 fixed the root cause and closed #18595. If a metadata-only defect remains after that fix, it should be reproduced through the real host-session mirror boundary with captured |

ELI5
When a paired remote Orca tab is mirrored locally, the local runtime can know that a terminal exists without having the remote repo registered locally. In that case
terminal listshould still show the useful tab title, worktree path, and restored preview instead of a blank row.What Changed
Why
This addresses a paired M1/Intel failure where direct remote inventory returned full terminal metadata, but the default local/federated terminal list showed remote rows with blank title/path/branch/preview. The fix keeps the existing host-scope semantics intact: mirrored runtime rows still do not claim authoritative host inventory coverage.
Linked Issue
Fixes #18595
Visual Proof
N/A. This is a runtime/CLI metadata fix covered by a regression test; no visual asset was changed.
Testing
Commands run on macOS:
Note: the global
pnpmshim on this machine is currently corrupted for the pinnedpnpm@12.0.0path, so I usednpm exec --yes pnpm@12.0.0for the local validation commands.AI Disclosure
AI assistance was used to diagnose the issue, implement the patch, and draft this PR.
Review
Self-reviewed for scope, host-scope truthfulness, and regression coverage.
Agent skill upstream boundary
docs/reference/agent-skill-sharing-upstream-boundary.mdand copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.Notes
Cross-platform impact should be low: the path fallback only parses the existing runtime worktree id format and is used only when no resolved worktree metadata exists.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)