Repository navigation
fix(cloud): stop asking setup-node to cache the pnpm store in the relay workflows - #18432
Conversation
…ay workflows setup-node's cache: pnpm runs 'pnpm store path' from the repository root, where packageManager pins pnpm 12; the shim it downloads fails to execute on the runner, so the step dies before auth. Cloud Verify never used the cache and passes; the six relay workflows that copied it from orca-cloud (root pnpm 10 there) now match.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughRemoved pnpm caching and lockfile cache dependency settings from six Relay production deployment and monitoring workflows. Node.js setup remains configured for version 24. Subsequent installation steps remain unchanged. Merge Risk: ⚪ Minimal · up to Relay workflows no longer attempt root-level pnpm cache setup, avoiding the pinned pnpm shim failure before authentication. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description accurately explains the failure, cause, scope, and intended fix. It does not follow the required template and omits the required Linked Issue, Visual Proof or N/A statement, Testing details, AI Disclosure, Review, boundary checkbox, Notes, and Checklist sections. Resolution Rewrite the description using the repository template. Add a linked issue after Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Removed
setup-nodepnpm cache config from six relay workflows — Dropscache: pnpmandcache-dependency-path: cloud/pnpm-lock.yamlfrom theactions/setup-node@v4step in thecloud-*relay workflows.
The change is correct and complete. Root package.json pins pnpm@12.0.0 while cloud/package.json pins pnpm@10.24.0; the workflows install the cloud pin via pnpm/action-setup@v4 (package_json_file: cloud/package.json). setup-node's cache: pnpm runs pnpm store path from the repository root, resolving the mismatched pnpm 12 shim and failing before auth. Removing the cache flag sidesteps that entirely, and the install itself (pnpm install --frozen-lockfile) is unaffected. Grep confirms no cache: pnpm or cache-dependency-path remains anywhere under .github/workflows/cloud-*.yml; the only surviving cache: pnpm uses are non-cloud workflows (mac/win build, release) that legitimately run the root pnpm 12 pin.
DeepSeek Pro (free via Pullfrog for OSS) ｜ 𝕏
…ay workflows (stablyai#18432) setup-node's cache: pnpm runs 'pnpm store path' from the repository root, where packageManager pins pnpm 12; the shim it downloads fails to execute on the runner, so the step dies before auth. Cloud Verify never used the cache and passes; the six relay workflows that copied it from orca-cloud (root pnpm 10 there) now match.
First public run of
cloud-monitor-relay-production(33746931085) died inactions/setup-nodebefore auth:cache: pnpmrunspnpm store pathfrom the repository root, wherepackageManagerpins pnpm 12, and the downloaded shim fails with a shell syntax error on the runner. Cloud Verify never used the cache and is green. Dropscache: pnpm+cache-dependency-pathfrom the sixcloud-*workflows that copied it from orca-cloud (whose root is pnpm 10).cloud-monitor-relay-clock-skewalready passed on the public repo.