[nwparker]

Summary\n- Split the preload bridge into domain-named API modules under .\n- Keep the public contract and IPC channel wiring intact.\n- Extend the web typecheck project to include the extracted preload support modules.\n\n## Validation\n- Native oxlint, node/CLI typechecks, max-lines ratchet, focused parity tests, and diff checks passed.\n- Web typecheck is blocked only by unrelated untracked browser-pane extraction files left out of this stack.\n\nStacked on the renderer runtime/store refactor (PR #17611).

[greptile-apps]

Greptile Summary

The PR splits the monolithic Electron preload facade into domain-specific bridge modules while retaining the existing public API and IPC wiring.

• Composes the extracted bridge modules in src/preload/index.ts.
• Moves shared preload initialization and listener support into preload-runtime-support.ts.
• Extends web typecheck coverage for extracted preload support files.
• Updates GitHub channel parity coverage for the split bridge owners.
• Preserves accepted session-tab snapshots during visibility-resume reconciliation.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains in the reviewed follow-up fixes.

No blocking failure remains.

Important Files Changed

Filename	Overview
src/preload/index.ts	Replaces the monolithic bridge implementation with composition of domain-specific API modules while retaining the exposed API boundary.
src/preload/preload-runtime-support.ts	Centralizes preload initialization helpers and shared listener state extracted from the former monolithic entry point.
src/preload/api/plugins-bridge.ts	Preserves the plugin bridge contract and consolidates its type imports to satisfy validation.
src/main/ipc/github-ipc-channel-parity.test.ts	Updates the GitHub IPC census to inspect both bridge-owner modules used by the composed facade.
src/renderer/src/runtime/web-session-tabs-sync/active-session-subscription.ts	Records snapshots as accepted only after they pass recovery, freshness, and apply gates.
src/renderer/src/runtime/web-session-tabs-sync/global-session-subscription.ts	Wires separate receipt and acceptance callbacks into visibility-resume coordination and resets both during cleanup.
config/tsconfig.tc.web.json	Adds the extracted preload support modules to the web typecheck project.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  R[Renderer] --> A[window.api]
  A --> I[src/preload/index.ts]
  I --> D[Domain bridge modules]
  D --> E[Electron ipcRenderer]
  E --> M[Main-process IPC handlers]

Loading

_{Reviews (8): Last reviewed commit: "chore(stack): restack preload on rendere..." | Re-trigger Greptile}

[pullfrog]

Important

The split itself is mechanically faithful — I diffed every ipcRenderer channel and method name against the pre-split index.ts and found zero drift (0 channels added/removed, 84/84 top-level keys, 821/821 method names). One thing needs confirmation first: the refactor silently adds a public method and changes one reload path's runtime behavior (details inline on app-bridge.ts).

Reviewed changes

• Split src/preload/index.ts into ~90 domain bridge modules under src/preload/api/, each owning its IPC contract; index.ts shrinks from ~5,300 lines to a ~200-line composer.
• Split the four oversized namespaces (browser, gh, pty, ui) across *-part-N.ts files merged by object spread.
• Extracted preload runtime support (before-unload checkpoint, native file drop, browser find forwarding, updater quit-abort relay) into preload-runtime-support.ts.
• Extended the web typecheck project to cover the extracted preload support modules.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Pro (free via Pullfrog for OSS) ｜ 𝕏}

[pullfrog]

The spread-merges for browser, gh, and pty have no satisfies PreloadApi['...'] annotation (unlike ui-bridge.ts:14), and the composed api object in index.ts is not asserted against PreloadApi. That means a method dropped or renamed during a future split edit would not be caught at compile time. Adding the same satisfies guard to the three merge files (or asserting the final composed object) would pin the full surface.

[greptile-apps]

Too many files changed for review (274 files, 100 file limit).

Bypass the limit by tagging @greptile-apps to review.

[nwparker]

Rebased onto current main (28373fc) — two removals

Removed the agentHooks bridge domain. This PR resurrected a preload domain (15 keys) that main deleted in #16089. There are no ipcMain.handle('agentHooks:…') handlers, no callers in renderer or mobile, and no entry in api-types.ts — agentHooks as a bridge key appears nowhere in origin/main. A pure refactor shouldn't revive a deleted subsystem. (The live src/main/agent-hooks/ installer subsystem is unrelated and untouched.)

Removed app.awaitBeforeUnloadCheckpoint. This PR newly exposed it on the bridge. It's arguably a fix — it's declared in app-api.ts and optionally called at lazy-chunk-recovery-reload.ts:55, so today that path resolves immediately instead of awaiting — but it is a behavior change and doesn't belong in a pure-refactor stack. Filed to land separately with a test.

Two dropped methods restored. An exposed-key census (origin/main = 1008 keys vs. split = 1036) found the split had silently dropped jira.searchUsers and runtimeEnvironments.retryControlConnection — both present in the pre-split baseline, both with live callers. Neither failed typecheck, because the bridge modules carry no satisfies PreloadApi and the shim's const api = {…} is unannotated; a dropped bridge method is a runtime undefined is not a function in the renderer. Restored, and the split is now a strict superset of main's exposed keys. Adding satisfies PreloadApi per module is filed as a follow-up.

Also ported main's preload delta from #17569, #17531, #17159.

[pullfrog]

ℹ️ No new issues in this restack.

Reviewed changes

• Restored awaitBeforeUnloadCheckpoint to a module-private helper — app-bridge.ts no longer exposes it on the public app bridge; it is passed only as the internal checkpoint argument to prepareAndInvokeAppRestart, so the renderer's optional-chain fallback in lazy-chunk-recovery-reload.ts is a silent no-op again, matching the pre-split contract.
• Re-split the bridge over the advanced renderer-stack base — absorbed the base branch's new preload surface (reportViewportScrollState, onScrollBrowserPage, retryControlConnection/observeOnly/onSharedControlDiagnostics, SSH keyboard-interactive prompts, terminal-split worktreeId/sourceLeafId) and its removal of the agentHooks namespace, with zero IPC-channel drift.
• Pruned the src/preload/index.ts max-lines baseline entry — the composer is back under budget.

IPC channel parity against the new base is clean: the only deltas are the pre-existing support-file channels (gitlab:*, updater:*, window:unload-prevented) documented in earlier reviews. The one remaining open suggestion — adding satisfies guards to the browser/gh/pty merge bridges and asserting the composed api — is unchanged by these commits and still tracked on its existing thread.

  ^{｜ Fix it ➔ ｜ View workflow run ｜ Using DeepSeek Pro (free via Pullfrog for OSS) ｜ 𝕏}