Repository navigation
Open linked reviews in Orca browser - #17360
Conversation
Greptile SummaryThe PR adds an “Open in Orca browser” action for linked review and issue URLs while preserving the currently selected workspace and surface.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/renderer/src/components/sidebar/use-worktree-card-secondary-details.ts | Routes linked issue and review URLs through the canonical workspace-browser helper and reports failures to the user. |
| src/renderer/src/lib/workspace-browser-tab-open.ts | Adds opt-in controls for inactive tab creation and non-selecting workspace behavior while retaining existing defaults. |
| src/renderer/src/components/sidebar/WorktreeCardMeta.tsx | Wires the new browser actions into issue and review detail sections while preserving hover dismissal. |
| src/renderer/src/components/sidebar/WorktreeCardIssueDetailSection.tsx | Adds the linked-issue browser action to the existing overflow menu. |
| src/renderer/src/components/sidebar/WorktreeCardReviewDetailSection.tsx | Adds a provider-neutral linked-review browser action alongside copy and unlink actions. |
Sequence Diagram
sequenceDiagram
participant U as User
participant C as Worktree card
participant H as Secondary-details handler
participant B as Workspace browser router
participant T as Browser tab
U->>C: Select Open in Orca browser
C->>H: Forward linked URL
H->>B: Open URL for owning workspace
B->>T: Create inactive browser tab
Note over T: Current workspace and surface remain selected
Reviews (4): Last reviewed commit: "ci: retry checks after cancelled rerun" | Re-trigger Greptile
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe change adds “Open in Orca browser” actions for linked issues and reviews. The actions pass linked URLs to workspace browser tab creation and show an error toast when opening fails. The UI exposes the actions only when URLs are available. Workspace browser tabs can now preserve the current focus and worktree selection. Tests cover callbacks, menu behavior, provider handling, and tab creation options. Merge Risk: ⚪ Minimal · up to The PR adds an Orca-browser action for linked reviews and issues while preserving existing link actions; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Title checkExplanation The title is concise and clearly describes the primary change: adding an Orca browser action for linked reviews. It does not mention linked issues, but the title does not need to cover every detail of the changeset. Full details: Description checkExplanation The description summarizes the implementation and verification, but it does not follow the required template. The Linked Issue section has no issue reference, the required Visual Proof is not attached or marked N/A, and the Testing checklist and platform details are missing. The ELI5, Why, Notes, Review, Agent skill boundary, and Checklist sections are also absent. Resolution Complete the required template sections. Add a valid Linked Issue reference, attach before-and-after visual proof after headed validation or mark it N/A with a reason, document manual and automated testing with tested platforms, and complete the remaining required checklist and review sections.
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
ℹ️ Minor suggestions only — the change is well-scoped, provider-neutral as advertised, and the tests pin real behavior. One UX question inline.
Reviewed changes
- "Open in Orca browser" menu action — adds a
Globeoverflow-menu item to both the linked-review and linked-issue detail sections, gated on a presenturl. - Background tab creation flags —
openWorkspaceBrowserTabgains optionalfocusOnCreateandselectWorktree; the client path mapsfocusOnCreatetoactivate, the runtime path forwards both, and defaults preserve prior always-activate / always-select behavior. - Caller wiring —
useWorktreeCardSecondaryDetailsopens the linked URL withfocusOnCreate: false, selectWorktree: falseand surfaces failures via a toast. - Tests — interaction tests pin exact URL forwarding, hover dismissal, and repeat-click forwarding;
workspace-browser-tab-opentests pin inactive client creation and runtime staging without worktree selection.
DeepSeek Pro (free via Pullfrog for OSS) ｜ 𝕏
| /** Keep the caller's current terminal/task surface selected while creating the tab. */ | ||
| focusOnCreate?: boolean | ||
| /** Keep the caller's current workspace selected while creating the tab. */ | ||
| selectWorktree?: boolean |
There was a problem hiding this comment.
These JSDoc comments describe only the false behavior, which is backwards from the field names — focusOnCreate: true activates, it does not "keep the current surface selected". Worth rephrasing so the default semantics are clear.
There was a problem hiding this comment.
ℹ️ No critical issues — the follow-up commit resolves the background-open UX concern. One minor scope question and a stale summary line remain.
Reviewed changes
- Linked tab now focuses —
openLinkedUrlInBrowserdropsfocusOnCreate: falseandselectWorktree: false, so "Open in Orca browser" activates the new tab and selects its worktree instead of opening invisibly.
ℹ️ Now-unused request flags
The focusOnCreate and selectWorktree fields on OpenWorkspaceBrowserTabRequest — plus their activate / focusOnCreate / selectWorktree wiring and the two tests that pin them — were introduced for this feature's background-open path. Now that the only caller relies on the defaults, no production code sets either flag. Worth deciding whether these stay as a general API for future callers or get trimmed until one exists.
Technical details
# Now-unused request flags
## Affected sites
- src/renderer/src/lib/workspace-browser-tab-open.ts:28-31 — flag definitions
- src/renderer/src/lib/workspace-browser-tab-open.ts:187, 291-292 — `activate` / `focusOnCreate` / `selectWorktree` mapping
- src/renderer/src/lib/workspace-browser-tab-open.test.ts:107-130, 192-216 — tests pinning the flags
## Open questions for the human
- Are these flags intended as a general API for upcoming callers, or leftovers from the abandoned background-open approach?ℹ️ Nitpicks
- The PR summary still reads "inactive creation so the current terminal/task view stays selected"; the code now focuses the tab and selects the worktree.
DeepSeek Pro (free via Pullfrog for OSS) ｜ 𝕏
* feat(sidebar): open linked reviews in Orca browser * test(e2e): match paired window reveal assertion * feat(sidebar): focus linked browser tabs * ci: retry checks after cancelled rerun
Summary
Verification
Electron screenshot proof will be attached separately after headed validation.