Repository navigation
Make worktree palette hint rows keyboard-clickable - #17272
Conversation
Hint entries like "See more" are now CommandItems that can be navigated with arrow keys and activated with Enter, instead of being non-interactive divs. This allows keyboard-only users to access the expand actions without mouse interaction.
Greptile SummaryThe PR makes worktree-palette hint rows selectable Command items and preserves selection near newly revealed entries after expansion.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/renderer/src/components/WorktreeJumpPalette.tsx | Converts overflow hints into selectable command rows and moves selection to the first newly revealed entry after expansion. |
| src/renderer/src/lib/worktree-palette-create-action.ts | Includes hint entries in the selectable palette ID sequence. |
| src/renderer/src/components/worktree-jump-palette-interleaved-sections.test.tsx | Updates command mocks and expansion assertions for selectable hint rows. |
| src/renderer/src/lib/worktree-palette-create-action.test.ts | Updates expected selectable IDs to include hint entries. |
Reviews (2): Last reviewed commit: "Make worktree palette "See more" keyboar..." | Re-trigger Greptile
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughHint entries now participate in keyboard selection while section headers remain excluded. Overflow “See more” rows render as selectable Merge Risk: ⚪ Minimal · up to This change makes existing worktree palette hint rows usable from the keyboard while preserving the existing expansion behavior. It is localized and introduces no actionable merge-blocking risk beyond normal checks and review. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description explains the problem and solution, but it omits required sections such as ELI5, Linked Issue, AI Disclosure, Review, Agent skill upstream boundary, and Notes. The Visual Proof entry incorrectly uses N/A for an interaction change, and the testing and checklist items remain unchecked. Resolution Add the missing required sections and a linked issue. Provide valid visual or interaction proof, or explain why it cannot be provided. Mark the applicable testing and checklist items, and document manual test platforms plus lint, typecheck, test, and build verification.
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Preserve cursor position when expanding via keyboard: auto-select the first newly revealed item at the previous index and restore input focus.
* Make worktree palette hint rows keyboard-clickable Hint entries like "See more" are now CommandItems that can be navigated with arrow keys and activated with Enter, instead of being non-interactive divs. This allows keyboard-only users to access the expand actions without mouse interaction. * Make worktree palette "See more" keyboard-navigable Preserve cursor position when expanding via keyboard: auto-select the first newly revealed item at the previous index and restore input focus.
Problem
Hint rows (like "5 more" indicators) in the worktree jump palette were not keyboard-accessible. Users navigating with arrow keys couldn't select or interact with them.
Solution
Converted hint rows from plain
<div>elements to<CommandItem>components so they participate in keyboard navigation. The "See more" action is now triggered via keyboard selection (Enter) or click. Addedhintto the selectable entry types list.Visual Proof
N/A — keyboard interaction change only, no visual changes.
Testing
Updated tests in
worktree-jump-palette-interleaved-sections.test.tsxandworktree-palette-create-action.test.tsto verify hint rows are now included in selection navigation.Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)