Skip to content

Make worktree palette hint rows keyboard-clickable - #17272

Merged
AmethystLiang merged 2 commits into
mainfrom
make-show-more-keyboard-clickable
Aug 29, 2026
Merged

AmethystLiang merged 2 commits into
mainfrom
make-show-more-keyboard-clickable

Conversation

@AmethystLiang

@AmethystLiang AmethystLiang commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​63 $\color{#cf222e}{\Huge{\mathbf{−}}}$​15 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​48
Prod 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​24 $\color{#cf222e}{\Huge{\mathbf{−}}}$​20 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​4

Problem

Hint rows (like "5 more" indicators) in the worktree jump palette were not keyboard-accessible. Users navigating with arrow keys couldn't select or interact with them.

Solution

Converted hint rows from plain <div> elements to <CommandItem> components so they participate in keyboard navigation. The "See more" action is now triggered via keyboard selection (Enter) or click. Added hint to the selectable entry types list.

Visual Proof

N/A — keyboard interaction change only, no visual changes.

Testing

  • I manually tested these changes locally
  • Automated tests added/updated, or explained why not below

Updated tests in worktree-jump-palette-interleaved-sections.test.tsx and worktree-palette-create-action.test.ts to verify hint rows are now included in selection navigation.

Checklist

  • This PR is small and focused
  • I explained what changed and why (including ELI5)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

Hint entries like "See more" are now CommandItems that can be navigated with arrow keys and activated with Enter, instead of being non-interactive divs. This allows keyboard-only users to access the expand actions without mouse interaction.
@greptile-apps

greptile-apps Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Greptile Summary

The PR makes worktree-palette hint rows selectable Command items and preserves selection near newly revealed entries after expansion.

  • Adds hint rows to the palette’s selectable entry types.
  • Converts “See more” hints into CommandItem entries with focus and selection restoration.
  • Updates selection and interaction tests for expanded hint rows.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/renderer/src/components/WorktreeJumpPalette.tsx Converts overflow hints into selectable command rows and moves selection to the first newly revealed entry after expansion.
src/renderer/src/lib/worktree-palette-create-action.ts Includes hint entries in the selectable palette ID sequence.
src/renderer/src/components/worktree-jump-palette-interleaved-sections.test.tsx Updates command mocks and expansion assertions for selectable hint rows.
src/renderer/src/lib/worktree-palette-create-action.test.ts Updates expected selectable IDs to include hint entries.

Reviews (2): Last reviewed commit: "Make worktree palette "See more" keyboar..." | Re-trigger Greptile

@coderabbitai

coderabbitai Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c7206c6f-2c2c-4167-a53b-7c3a48c54a32

📥 Commits

Reviewing files that changed from the base of the PR and between 89e7695 and 0e1fa25.

📒 Files selected for processing (2)
  • src/renderer/src/components/WorktreeJumpPalette.tsx
  • src/renderer/src/components/worktree-jump-palette-interleaved-sections.test.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Hint entries now participate in keyboard selection while section headers remain excluded. Overflow “See more” rows render as selectable CommandItems and invoke entry.onSeeMore through onSelect. The handler restores selection at the same index after expansion and refocuses the input. Tests update command mocks, selection IDs, focus assertions, and worktree item counts.

Merge Risk: ⚪ Minimal · up to 0e1fa

This change makes existing worktree palette hint rows usable from the keyboard while preserving the existing expansion behavior. It is localized and introduces no actionable merge-blocking risk beyond normal checks and review.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the problem and solution, but it omits required sections such as ELI5, Linked Issue, AI Disclosure, Review, Agent skill upstream boundary, and Notes. The Visual Proof entry in… Add the missing required sections and a linked issue. Provide valid visual or interaction proof, or explain why it cannot be provided. Mark the applicable testing and checklist items, and document manual test platforms plus lint, typecheck,…
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: making worktree palette hint rows keyboard-clickable.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem and solution, but it omits required sections such as ELI5, Linked Issue, AI Disclosure, Review, Agent skill upstream boundary, and Notes. The Visual Proof entry incorrectly uses N/A for an interaction change, and the testing and checklist items remain unchecked.

Resolution

Add the missing required sections and a linked issue. Provide valid visual or interaction proof, or explain why it cannot be provided. Mark the applicable testing and checklist items, and document manual test platforms plus lint, typecheck, test, and build verification.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Preserve cursor position when expanding via keyboard: auto-select the first
newly revealed item at the previous index and restore input focus.
@AmethystLiang
AmethystLiang merged commit 67fa855 into main Aug 29, 2026
26 checks passed
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
* Make worktree palette hint rows keyboard-clickable

Hint entries like "See more" are now CommandItems that can be navigated with arrow keys and activated with Enter, instead of being non-interactive divs. This allows keyboard-only users to access the expand actions without mouse interaction.

* Make worktree palette "See more" keyboard-navigable

Preserve cursor position when expanding via keyboard: auto-select the first
newly revealed item at the previous index and restore input focus.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant