Skip to content

chore: update oxlint and oxfmt - #17150

Merged
nwparker merged 1 commit into
stablyai:mainfrom
nwparker:nwparker/update-oxc-tools
Aug 29, 2026
Merged

nwparker merged 1 commit into
stablyai:mainfrom
nwparker:nwparker/update-oxc-tools

Conversation

@nwparker

Copy link
Copy Markdown
Contributor

Summary

  • update oxlint from 1.77.0 to 1.80.0
  • update oxfmt from 0.52.0 to 0.65.0
  • preserve the existing lint policy across oxlint’s React Compiler rule split
  • rename intentionally ignored bare underscore bindings for the new no-unused-vars behavior
  • reformat files required by oxfmt 0.65.0

Validation

  • pnpm exec oxlint
  • pnpm exec oxfmt --check .
  • pnpm run check:code-quality:changed
  • pnpm tc
  • pnpm test src/main/pi/agent-status-extension-source.test.ts

All passed.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1b62c4de-3235-4bee-a238-1a47e6077f71

📥 Commits

Reviewing files that changed from the base of the PR and between 40d8dc72c13894fb493df9ded18e844476a28d84 and 0375841.

⛔ Files ignored due to path filters (2)
  • mobile/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • mobile/package.json
  • package.json
  • src/renderer/src/components/WorktreeJumpPalette.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates oxfmt and oxlint, disables twelve React lint rules, and reformats callbacks, handlers, loops, imports, mocks, and object literals across mobile, main, renderer, shared, and E2E code. It also adds workspace-cleanup test coverage for batched progress reporting. Runtime behavior and existing test data remain unchanged.

Merge Risk: ⚪ Minimal · up to 03758

This PR updates linting and formatting tools while preserving the existing policy and application behavior. The listed checks pass, and no actionable merge-blocking risk remains beyond normal review.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the dependency updates and lists validation results, but it does not use the repository template and omits required sections, including ELI5, What Changed, Why, Linked Issue, … Update the description to use all template headings. Add a valid issue reference after "Fixes #", write "N/A" with a reason under Visual Proof, provide testing details and platforms, complete the required checkboxes, and address AI Disclosu…
Docstring Coverage ⚠️ Warning Docstring coverage is 14.81% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 27 functions across 49 files. (2 skipped:… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: updating oxlint and oxfmt.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the dependency updates and lists validation results, but it does not use the repository template and omits required sections, including ELI5, What Changed, Why, Linked Issue, Visual Proof, Testing, Review, Agent skill upstream boundary, Notes, and Checklist.

Resolution

Update the description to use all template headings. Add a valid issue reference after "Fixes #", write "N/A" with a reason under Visual Proof, provide testing details and platforms, complete the required checkboxes, and address AI Disclosure and the remaining template sections.

Full details: Docstring Coverage

Explanation

Docstring coverage is 14.81% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 27 functions across 49 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Greptile Summary

Updates oxlint and oxfmt while preserving the existing lint policy.

  • Upgrades oxlint to 1.80.0 and oxfmt to 0.65.0 in desktop and mobile manifests and lockfiles.
  • Disables newly split React Compiler rules to retain the prior lint behavior.
  • Renames intentionally unused bindings and applies formatter-driven changes across source and test files.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
.oxlintrc.json Explicitly disables the newly split React Compiler rules to preserve the existing lint policy.
package.json Updates the root oxlint and oxfmt development dependencies.
mobile/package.json Updates the mobile workspace’s oxlint and oxfmt development dependencies.
pnpm-lock.yaml Regenerates root dependency resolutions for the updated tooling.
mobile/pnpm-lock.yaml Regenerates mobile dependency resolutions for the updated tooling and existing React Native patch metadata.

Reviews (2): Last reviewed commit: "chore: update oxlint and oxfmt" | Re-trigger Greptile

@nwparker
nwparker force-pushed the nwparker/update-oxc-tools branch from 40d8dc7 to 0375841 Compare August 29, 2026 20:59
@nwparker
nwparker merged commit 2dfaa67 into stablyai:main Aug 29, 2026
30 checks passed
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant