Repository navigation
refactor Git repository host boundaries - #16177
Merged
nwparker merged 2 commits intoAug 25, 2026
Merged
Conversation
Contributor
|
Warning Review limit reachedNext included review available in 6 seconds. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (19)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
paidaxingyo666
pushed a commit
to paidaxingyo666/Manta
that referenced
this pull request
Aug 25, 2026
(cherry picked from commit 07b13c8)
dallascrilley
pushed a commit
to dallascrilley/orca
that referenced
this pull request
Aug 27, 2026
This was referenced Sep 29, 2026
nwparker
added a commit
that referenced
this pull request
Sep 29, 2026
Fifth audit wave, renderer-scoped. Same shape as #23941: delete private-predicate cases whose behavior is already asserted through the module's real entry point, then make the symbol module-private again. Two whole files went as provider-local replays: `terminal-paste-payload-metadata` (same corpus, same inputs, same expectations as `lib/paste-payload-metadata`, just renamed symbols) and `repro-8784-ghe-avatar-fallback` (every case now asserted through the rendered component in `github-user-avatar.test.tsx`). Dead production code removed where tests were its only callers: `resolveImeModifierGesture`, `isCodexTerminalStartupCommand` (its codex branches are covered by `isKnownTuiAgentTerminalStartupCommand`), `reconcileSelectionKeys` (superseded by `reconcileSourceControlSelectionState`, which the hook calls), and `chatFontScaleShortcutLabels` (nothing renders those labels). Roughly three quarters of the flagged modules were detector false positives and were left untouched; the scanner cannot see re-export barrels, `.web.ts` platform variants, build-time overrides, or `*ForTests` inspection seams. `accumulateWorkItemPages` is deliberately NOT deleted despite having only test callers. It, the dead `filesystem-directory-listing-limit` module, and `resolveImeModifierGesture` all landed unwired in the same refactor (#16177), and unwired page accumulation is more likely a lost wiring step than dead weight. Deleting it would erase that evidence.
9 tasks done
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- split repository detection, Git marker scanning, default-base resolution, ref search, and branch-conflict logic behind the existing repo facade\n- split SSH Git reads, noninteractive operations, working-tree state, remote sync, review-head handling, and worktree operations behind the existing provider class\n- preserve host-owned execution, per-instance caches and queues, Git 2.25 fallback behavior, folder workspaces, and all public APIs\n- remove only the two stale max-lines baseline entries\n\n## Validation\n\n- 18 serial focused test files, 193 tests, including repo export and SSH method parity locks\n- supplemental default-remote suite: 6 tests\n- node typecheck\n- targeted oxlint and oxfmt\n- changed-code quality: 0 findings\n- max-lines and runtime-Electron ratchets\n- production line audit: all files at or below 300 lines\n- independent repository review: no findings\n- clean post-rebase divergence: 0 behind / 1 ahead\n\n## Risk\n\nCross-platform and remote behavior is covered by focused native, WSL, SSH, relay, routing, compatibility, and authority tests. No live SSH/WSL host or real Git 2.25 binary matrix was exercised locally.