Skip to content

Break up large files into well-organized modules (Settings.tsx + TerminalPane.tsx) - #16049

Closed
64ix wants to merge 1 commit into
stablyai:mainfrom
64ix:spec/29-break-up-large-files
Closed

64ix wants to merge 1 commit into
stablyai:mainfrom
64ix:spec/29-break-up-large-files

Conversation

@64ix

@64ix 64ix commented Aug 23, 2026

Copy link
Copy Markdown

Summary

Implements the remaining gap of spec #29. The original PR split 4 oversized files; on current main, two of them have regrown past their max-lines budgets and sit behind grandfathered suppressions:

  • src/renderer/src/components/settings/Settings.tsx — 1931 lines
  • src/renderer/src/components/terminal-pane/TerminalPane.tsx — 3297 lines

This PR splits both into focused domain modules under their existing folders (components/settings/, components/terminal-pane/), removes their eslint-disable max-lines suppressions, and shrinks config/max-lines-baseline.txt accordingly (ratchet baseline may only shrink).

Spec & Tickets

Acceptance criteria

Criterion Verdict Evidence
Settings.tsx under tsx budget (400 effective lines), suppression removed ⏳ —
TerminalPane.tsx under tsx budget, suppression removed ⏳ —
New modules in domain folders, no barrel exports, no util/helper naming ⏳ —
No new max-lines bypasses; ratchet baseline shrinks by exactly 2 ⏳ —
Typecheck, oxlint, unit tests pass ⏳ —

QA plan

  • pnpm run typecheck passes
  • pnpm run lint passes (incl. check:max-lines-ratchet)
  • Settings window opens and renders all panes
  • Terminal pane: split / resize / context menu / paste work
  • Existing unit tests for settings + terminal-pane pass

@64ix

64ix commented Aug 23, 2026

Copy link
Copy Markdown
Author

Created in error — this work belongs on the fork. Closing.

@64ix 64ix closed this Aug 23, 2026
@64ix
64ix deleted the spec/29-break-up-large-files branch August 23, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant