Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📥 CommitsReviewing files that changed from the base of the PR and between cd31c8c137b6a84644f1e2b59822db6778e42ff9 and 4120c9a. 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughAdded Priority: ➖ Normal Severity of issue fixed: Medium 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
18abb20 to
e07fa05
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Team
Run ID: e79679ac-f893-4045-bc00-3d5c2fe6b028
📥 Commits
Reviewing files that changed from the base of the PR and between 7f6cf27 and e07fa05d53be131f3dc59c9cde4b522246c74611.
📒 Files selected for processing (10)
src/main/github/gh-api-json-input.test.tssrc/main/github/gh-api-json-input.tssrc/main/github/issue-comment.tssrc/main/github/issue-create.tssrc/main/github/issue-update.tssrc/main/github/issues.test.tssrc/main/github/project-view/issue-comment-mutations.test.tssrc/main/github/project-view/issue-comment-mutations.tssrc/main/github/project-view/mutations.test.tssrc/main/github/project-view/mutations.ts
🚧 Files skipped from review as they are similar to previous changes (6)
- src/main/github/issue-comment.ts
- src/main/github/gh-api-json-input.test.ts
- src/main/github/gh-api-json-input.ts
- src/main/github/issues.test.ts
- src/main/github/issue-update.ts
- src/main/github/issue-create.ts
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.
e07fa05 to
cd31c8c
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
cd31c8c to
4120c9a
Compare
ELI5
Pasted screenshots can make issue or PR bodies larger than Windows can pass on a command line. The issue and project-view body-writing calls covered here now read JSON from a temporary file instead of placing the body on argv.
What Changed
withGhApiJsonInputfor issue creation, edits, comments, project-view issue/comment edits, and PR-slug body edits.bba68b1bddf1276c8bd27ad4ca41efcbd4260321and added PR-slug regression coverage.Why
The original branch still placed PR-slug bodies on argv and changed title-only transport despite describing it as unchanged. Both paths now match the stated contract. No new dependency or wire change.
Linked Issue
Fixes #15832
Visual Proof
N/A — request serialization and subprocess argv only.
Testing
RED: 4 regression assertions failed before the follow-up fix. GREEN: 35 tests across
issues.test.ts,gh-api-json-input.test.ts,project-view/mutations.test.ts,project-view/issue-comment-mutations.test.ts, andproject-view/pull-request-mutation.test.ts; another 10 map-with-concurrency smoke tests passed.Node, CLI, and Web TypeScript checks passed using the repository's non-composite configuration (
tsc --noEmit -p config/tsconfig.{node,cli,web}.json --composite false, run separately). Changed-file oxlint, oxfmt, and diff checks passed. Tool versions match package.json.Default composite typecheck reports TS2883 in unchanged files. Its Node diagnostic set was also reproduced on pristine base
bba68b1bdd; it is not reported as passing. Full suite/build and live Windows/SSH/GHES execution were not run.Existing assertion change: restored the GHES title-only assertion to
--raw-field title=New title; the former branch assertion incorrectly required--input. Body tests read the real temporary file during mocked network execution; the serialization helper and mutation functions are not mocked.AI Disclosure
Original implementation: Grok. Follow-up: Codex; independent Cursor review passed for tree
eda0c0a83aeb6532eaa20e6220e760da48e9e396, committed unchanged ascd31c8c137b6a84644f1e2b59822db6778e42ff9.Review
GitHub/GHES-specific API paths only. Folder workspaces use the OS temporary directory; existing execution-host and WSL path translation remain in place. Error propagation and temporary cleanup are covered, including empty and 140 KB bodies.
Agent skill upstream boundary
Checklist