Repository navigation
fix(package): keep cached dev Electron bundles out of app.asar - #15359
Merged
Merged
Conversation
`files` is an all-negation list, so electron-builder's default `**/*` packs anything without an explicit `!` entry. out/electron-dev holds `pnpm dev`'s per-branch Electron.app copies (~270MB each), so packaging on a machine that has run dev bundled them all. CI never creates the directory, so releases were never affected.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Electron Builder configuration now excludes ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
paidaxingyo666
pushed a commit
to paidaxingyo666/Manta
that referenced
this pull request
Aug 21, 2026
…yai#15359) `files` is an all-negation list, so electron-builder's default `**/*` packs anything without an explicit `!` entry. out/electron-dev holds `pnpm dev`'s per-branch Electron.app copies (~270MB each), so packaging on a machine that has run dev bundled them all. CI never creates the directory, so releases were never affected.
dallascrilley
pushed a commit
to dallascrilley/orca
that referenced
this pull request
Aug 27, 2026
…yai#15359) `files` is an all-negation list, so electron-builder's default `**/*` packs anything without an explicit `!` entry. out/electron-dev holds `pnpm dev`'s per-branch Electron.app copies (~270MB each), so packaging on a machine that has run dev bundled them all. CI never creates the directory, so releases were never affected.
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
…yai#15359) `files` is an all-negation list, so electron-builder's default `**/*` packs anything without an explicit `!` entry. out/electron-dev holds `pnpm dev`'s per-branch Electron.app copies (~270MB each), so packaging on a machine that has run dev bundled them all. CI never creates the directory, so releases were never affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
pnpm devleaves a ~270MB copy of Electron.app inout/electron-devfor every branch you build. If you packaged the app on that same machine, all of those copies got stuffed into the shippedapp.asar. One line tells electron-builder to skip that directory.What Changed
config/electron-builder.config.cjs: added'!out/electron-dev{,/**/*}'tofiles.config/scripts/electron-builder-config.test.mjs: a matcher-driven test that dev bundle paths are excluded whileout/mainandout/rendererstill pack.Why
filesis an all-negation list, so electron-builder's default**/*packs anything without an explicit!entry.out/is gitignored, but electron-builder globs the filesystem, not git — soout/electron-dev/<hash>/Orca: dev.app/**was fair game.This is the same shape as the
examples/miss that shippedhostile-panelin 1.4.160-rc.3, which is why the test drives the realFileMatcherinstead of pinning the pattern string: asserting the glob exists cannot prove it excludes the tree.Release builds were never affected — CI runners never run
pnpm dev, soout/electron-devdoes not exist there. The exposure is local packaging only (pnpm build:mac/build:unpackon a dev machine), where it showed up as silent bulk rather than a failure.Noticed while reviewing #15247, which prunes stale bundles from that same directory and so already shrank the worst case.
Linked Issue
No separate issue — follow-up to #15247.
Visual Proof
N/A — packaging input filter only. No runtime code, UI, or user-visible behavior changes.
Testing
pnpm exec vitest run config/scripts/electron-builder-config.test.mjs→ 34 passed.Mutation-verified: with the
!out/electron-dev{,/**/*}line removed, the new test fails; restored, it passes. Without that step the test would pass either way.Also clean:
oxlint,oxfmt --check,check:max-lines-ratchet.Not run locally: a full
pnpm build:mac. The assertion is on electron-builder's ownFileMatcherwith the real config, which is the component that decides packing.