Skip to content

ci: render LoC + and - signs huge bold - #14855

Merged
nwparker merged 1 commit into
stablyai:mainfrom
nwparker:nwparker/test-loc-sign-big
Aug 16, 2026
Merged

nwparker merged 1 commit into
stablyai:mainfrom
nwparker:nwparker/test-loc-sign-big

Conversation

@nwparker

Copy link
Copy Markdown
Contributor

What Changed

Follow-up to #14839: the + and − signs in the test vs non-test LoC table are now huge and bold.

  • + renders green (#1a7f37), − renders red (#cf222e), via $\color{...}{\Huge{\mathbf{+}}}$
  • Digits stay in the normal body font; zero stays plain

Example

Files Added Deleted Net
Test 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​175 $\color{#cf222e}{\Huge{\mathbf{−}}}$​12 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​163
Prod 4 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​350 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​350

Testing

  • pnpm exec vitest run --config config/vitest.config.ts config/scripts/pr-test-loc-summary.test.mjs (9 passed)
  • oxlint clean

@nwparker
nwparker merged commit 8dc29a5 into stablyai:main Aug 16, 2026
45 checks passed
@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ffc8955-e12c-4c1c-bb42-c24b7421ca02

📥 Commits

Reviewing files that changed from the base of the PR and between ac48d75 and df14f05.

📒 Files selected for processing (2)
  • .github/scripts/pr-test-loc-table.mjs
  • config/scripts/pr-test-loc-summary.test.mjs

Included review availability: Your plan includes up to 10 reviews per rolling hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The change updates diff table formatting to use enlarged, bold plus and minus symbols. Existing colors and count values remain unchanged. Tests now expect the updated formatting for direct rendering, header replacement, and CLI fixture output.

Merge Risk: 🔵 Low · up to df14f

This PR changes the visual styling of plus and minus signs in the LoC table. It is otherwise mergeable, but the owner should confirm that the signs render bold in the target Markdown renderer and adjust the macro if needed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and testing, but it omits required ELI5, Why, Linked Issue, Visual Proof, Review, Checklist, and Author sections. Add the required template sections, including a linked issue, before-and-after visual proof or N/A with a reason, review notes, checklist status, and author details.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change to render LoC plus and minus signs as huge and bold.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

AmethystLiang pushed a commit that referenced this pull request Aug 17, 2026
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant