Repository navigation
Conversation
Runtime-hosted repos have connectionId null, so the mobile new-tab agent menu fell through to preflight.detectAgents on the paired host. Prefer executionHostId and proxy via host-side preflight.detectRuntimeAgents so the menu lists agents installed on the runtime that owns the workspace. Fixes #13752
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds runtime agent detection for repositories owned by runtime execution hosts. The flow validates and resolves the environment, invokes paired 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as superseded by the current workspace-scoped detection and direct-pair policy on main ( The original bug was presenting the paired host's agents for a workspace owned by another runtime. Main now advertises an explicit other-runtime refusal capability. This replaces the proposed cross-runtime proxy/fallback design and removes the incorrect-owner detection behavior that motivated the PR. Reviewed the complete functional diff and current client/server routing; no tests or emulator run were performed for this audit. |
Summary
repo.connectionIdonly, so runtime-hosted repos (connectionId: null) probed the paired host instead of the runtime execution owner.preflight.detectRuntimeAgentsthat proxiespreflight.detectAgentsto a registered paired runtime environment (authorization: environment must exist in the host store; loop prevention: remote hop never re-delegates).executionHostId(runtime → SSH → local/connectionId) and falls back to paired-host detection when the host predates the new RPC.Fixes #13752
Wire compatibility
method_not_foundfalls back topreflight.detectAgents(previous behavior, not a hard failure).preflight.detectAgentsso a runtime host cannot re-proxy.Testing
pnpm exec vitest run—preflight-runtime-agent-detection.test.ts,preflight.test.ts(RPC),mobile-rpc-allowlist.test.tscd mobile && pnpm exec vitest run src/session/mobile-new-tab-agent-loader.test.ts(6 tests)pnpm run typecheck:nodetsc --noEmitRemaining gaps
NewWorktreeModaland tasks workspace-create agent detection still use connectionId-only resolution (same class of bug, out of new-tab menu scope).