Repository navigation
feat(orchestration): QoL bundle — preamble visibility, status enum, dispatch xref, inbox --full - #1392
Closed
Jinwoo-H wants to merge 1 commit into
Closed
feat(orchestration): QoL bundle — preamble visibility, status enum, dispatch xref, inbox --full#1392Jinwoo-H wants to merge 1 commit into
Jinwoo-H wants to merge 1 commit into
Conversation
…ispatch cross-ref, inbox --full Addresses four items from ORCHESTRATOR_FEEDBACK: - #5 preamble visibility: `dispatch-show --preamble` regenerates the preamble text for a task; `dispatch --inject --dry-run` previews without mutating state; `dispatch --return-preamble` echoes the injected preamble in the JSON response so coordinators can audit what a worker received. - #6 status enum validation: CLI rejects unknown `task-update --status` values with `invalid status '<x>', expected one of: pending, ready, dispatched, completed, failed, blocked` before the RPC's generic Zod message. Valid statuses are listed under Notes in `task-update --help`. - #13 task-list dispatch cross-ref: `task-list --json` now includes `assignee_handle` and `dispatch_id` for tasks in status=dispatched via a read-only LEFT JOIN on dispatch_contexts. Non-dispatched rows keep their legacy shape so existing consumers are unaffected. - #14 inbox body visibility: `inbox --full` prints body + payload verbatim; default output is unchanged (id/from/to/subject only). No DB migrations; join-only change on dispatch_contexts so the sibling preamble PR's `last_heartbeat_at` column addition will not conflict. Co-authored-by: Orca <help@stably.ai>
15 tasks done
Contributor
Author
|
Superseded by #1403, which bundles this PR with the other three orchestration improvement PRs and resolves the merge conflicts they shared. Branch preserved for diff comparison — not deleting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small, independently reviewable bundle of orchestration QoL fixes spanning 4 items from
ORCHESTRATOR_FEEDBACK.md:dispatch-show --preamble [--from <handle>]regenerates the preamble for any task;dispatch --inject --dry-runreturns preamble text without mutating state;dispatch --return-preambleechoes injected preamble in JSON response--statuswithinvalid status '<x>', expected one of: pending, ready, dispatched, completed, failed, blockedbefore hitting the RPC;task-update --helplists valid statusesOrchestrationDb.listTasksWithDispatch()with LEFT JOIN ondispatch_contexts(active dispatches only).taskListRPC surfacesassignee_handle+dispatch_idfor tasks instatus=dispatched; non-dispatched rows keep legacy shape--fullflag prints body + payload verbatim; default output unchangedDeliberately out of scope: items 8 (handle stability) and 10 (run scoping) — larger refactors that deserve their own design cycle.
Test plan
pnpm typecheckcleanpnpm lintcleantask-list --json— verifyassignee_handlepopulatedtask-update --status invalid— verify clear errordispatch-show --preamble <id>— verify preamble returnedinbox --full— verify no truncation on a long-body message