Repository navigation
Conversation
6664acc to
795c995
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughAdded Korean localization for artifact settings, sidebar navigation, account settings, sharing, publishing, previews, pagination, authentication, expiration, file constraints, validation, and error states. Merge Risk: ⚪ Minimal · up to This localized string update is limited to the Korean catalog and does not change application behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The Artifacts sidebar entry, settings pane, share flow, and publish dialogs shipped with no Korean translations. Fill in the 120 missing keys under auto.components.artifacts, auto.components.settings.artifacts, auto.components.settings.orcaAccount, and related sidebar/navigation entries in ko.json.
795c995 to
7c6a66f
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Rebased onto The conflict was purely additive on both sides: @brennanb2025 whenever you have a moment — happy to adjust any wording. |
Resolve ko.json artifacts conflict: keep the shipped wording from the artifacts page redesign (stablyai#15233), drop keys it removed, translate the ones it added. # Conflicts: # src/renderer/src/i18n/locales/ko.json
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5cc0f65a-0e22-477d-8af1-a862b6b88400
📒 Files selected for processing (1)
src/renderer/src/i18n/locales/ko.json
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.
…tring The English source reads "Load the next page to continue." The Korean copy had the purpose and action clauses swapped, which inverted the meaning.
|
Thanks @zz1996zz — the Korean Artifacts strings are already translated on main, so there's nothing left to apply here. Closing as already fixed. |
Summary
The Artifacts sidebar entry, settings pane, share flow, and publish dialogs shipped with no Korean translations (
ko.jsonhad 0 of the 82auto.components.artifacts.*keys, plus related settings/sidebar keys, all falling back to English).Fills in the 120 missing keys across
auto.components.artifacts,auto.components.settings.artifacts,auto.components.settings.orcaAccount, and the sidebar/settings-navigation entries insrc/renderer/src/i18n/locales/ko.json.Translates "artifact" as "아티팩트" (the standard loanword for build/CI artifacts among Korean developers), keeps
Orca,HTML,Markdownuntranslated per the existing catalog policy, and matches terminology already used elsewhere inko.json(삭제, 새로고침, 다시 시도, 로그인, 링크 복사, 닫기, 미리보기, etc.).No English source, source code, or other locale files were touched — this is a
ko.json-only change, consistent with the sparse-target-catalog architecture described inconfig/i18n-translation-source.md.Screenshots
No visual change — this PR only adds translated strings to an existing, already-shipped UI surface. No new components, layouts, or styling.
Testing
pnpm lintpnpm typecheckpnpm testpnpm buildNotes on the above:
pnpm lintandpnpm typecheckpass cleanly.pnpm buildcompletes successfully end to end (desktop + native).pnpm test: full suite is 49,951 tests; 5 failed on the first full run, all in files unrelated to this change (agent-exec-handler.test.ts,run-electron-vite-dev.test.ts,ai-vault-session-worktree-map.test.tsx,terminal-output-frame-chunks-equivalence.test.ts). Re-ran each failing file in isolation: 4 of the 5 failures were parallel-run resource/timing flakiness and pass individually; the remaining 2 (agent-exec-handler.test.ts) fail only because my shell session has Claude Code/git env vars injected (CLAUDECODE,GIT_CONFIG_COUNT=4, etc.) that the test's environment-passthrough assertion doesn't expect — a local environment artifact, not a regression from this change. None of the failing files touch i18n, locales, orko.json.node config/scripts/verify-localization-catalog.mjs— no extra/missing keys, no interpolation-placeholder mismatches, no generic-term regressions;ko.jsoncoverage increased with the new keys.pnpm run verify:localization-extraction— passes (pre-existing unrelated diffs unchanged by this PR).pnpm run verify:localization-coverage— passes.{{placeholder}}interpolation matches its English source exactly, and that key ordering inko.jsonmatchesen.jsonfor the touched sections.AI Review Report
Reviewed the diff against
config/i18n-translation-source.mdand the existingko.jsonconventions before writing translations: confirmed this change only needed to touch the sparse target locale file (English source and other locales untouched), checked that{{placeholder}}interpolation tokens are preserved verbatim in every translated string, and cross-referenced existingko.jsonentries to keep terminology consistent (e.g. 삭제/새로고침/다시 시도/로그인/링크 복사/닫기/미리보기) rather than inventing new phrasing per string.This PR does not touch any platform-specific code paths (no shortcuts, no file path handling, no shell invocation, no Electron APIs), so cross-platform behavior for macOS, Linux, and Windows is unaffected — it is a pure data change to one JSON locale file consumed identically on every platform.
Security Audit
No input handling, command execution, path handling, auth, secrets, dependency, or IPC changes. This PR only adds static translated string literals to an existing, version-controlled JSON locale file that is bundled at build time — no new user-controlled data paths are introduced.
Notes
No platform-specific behavior or follow-up work. This is a translation-only change limited to
src/renderer/src/i18n/locales/ko.json.