Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📥 CommitsReviewing files that changed from the base of the PR and between dd8d81e263061dce378e0857aa754c5f0036cb30 and 72261ca. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe headless Linux server guide now documents commands for inspecting bundled skills and reading guides. It adds skill installation examples, verification steps, integration requirements, credential handling, and host-specific requirements. It also explains how to refresh skills after upgrades and clarifies that install and update commands run on the executing host, with SSH and WSL forwarding behavior documented. Priority: ⬇️ Low 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the main documentation changes, includes issue Resolution Rewrite the description using the repository template. Complete ELI5, What Changed, Why, Linked Issue, Visual Proof, Testing, AI Disclosure, Review, Agent skill upstream boundary, Notes, and Checklist sections. Mark Visual Proof as N/A with a reason if no UI or interaction changes exist, and document the relevant validation and platform considerations.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: bb86e594-e075-4b83-afb1-9caa7c2ceb9c
📥 Commits
Reviewing files that changed from the base of the PR and between 04f7123 and 1f2d460bb5d750f2af865f26ca503b20dbfa8b05.
📒 Files selected for processing (1)
docs/reference/headless-linux-server.md
Review follow-up (batch 4)Addressed confirmed medium findings from campaign review:
Also prefer |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/reference/headless-linux-server.md (1)
789-790: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winUse
updateor reinstall to refresh agent-side guides.
orca skills getand rereading a guide only display the bundled guide. They do not update copies already installed for agents. Replace “re-read or re-install” with “runorca skills updateor reinstall” so this section matches the later upgrade procedure.
♻️ Duplicate comments (1)
docs/reference/headless-linux-server.md (1)
860-867:⚠️ Potential issue | 🟠 MajorKeep
GH_TOKENout of agent environments.The guide permits
GH_TOKENin the environment of the same user that runs agents, then recommends environment variables. Iforca serveinherits that variable, child agent processes can read it. Documentghcredential-store authentication or a helper that injectsGH_TOKENonly for theghcommand. Verify child-process environment filtering before retaining this guidance.#!/bin/bash set -euo pipefail rg -n -C 8 'GH_TOKEN|GITHUB_TOKEN|process\.env|spawn|fork|exec|env:' . \ --glob '!node_modules' --glob '!dist' --glob '!build' || true
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 767ab795-7e69-4eea-a09b-871d61eb1ff1
📥 Commits
Reviewing files that changed from the base of the PR and between 1f2d460bb5d750f2af865f26ca503b20dbfa8b05 and 498264d285ffa8399ebbec8e9fb1db4367353308.
📒 Files selected for processing (1)
docs/reference/headless-linux-server.md
…i#11885) Document which skills ship with the CLI, common serve install sets, integration/secret handling for Linear/GitHub/computer-use, and update/verify steps so headless orca serve operators need not use Settings.
…T-SPI setup Review follow-up for stablyai#13262: Linear is runtime-token based (not skill env secrets), skills get is not install proof, and computer-use needs AT-SPI session bus rather than macOS-style accessibility + Xvfb alone.
Campaign review follow-up for stablyai#13262: prove installs via agent skill dirs (not skills get), document linear.connect/UI tokens under ~/.orca, and spell out python3-gi/AT-SPI session-bus requirements for computer-use.
dd8d81e to
72261ca
Compare
Summary
Headless
orca serveoperators already hadorca skills install/updatein the Linux server reference, but not a full path for discovering skills, installing the common serve set (CLI, orchestration, Linear, computer-use), handling integrations/secrets, or verifying after upgrade.skills getfor reading without installFixes #11885
Test plan
pnpm exec vitest run src/main/startup/single-instance-lock-headless-exit.test.ts