Skip to content

feat: implement hierarchical tree view for PR diff file list fixes #1109 - #1278

Merged
Jinwoo-H merged 2 commits into
stablyai:mainfrom
mrayushmehrotra:feat/diff-tree-view
Apr 30, 2026
Merged

Jinwoo-H merged 2 commits into
stablyai:mainfrom
mrayushmehrotra:feat/diff-tree-view

Conversation

@mrayushmehrotra

@mrayushmehrotra mrayushmehrotra commented Apr 30, 2026 •

Copy link
Copy Markdown

Summary

Describe the user-visible change.

feat: implement hierarchical tree view for PR diff file list

  • Added pr-diff-tree.ts for grouping flat file paths into a directory tree.
  • Implemented folder compaction (e.g. src/main/java) to reduce vertical noise.
  • Added Flat/Tree view toggle buttons to the GitHub PR dialog's Files tab.
  • Updated PRFileRow to support nested indentation and basename-only display in tree mode.
  • Added unit tests for tree construction and compaction logic.

Screenshots

image - Add screenshots or a screen recording for any new or changed UI behavior.

Testing

  • [x ] pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm build
  • Added or updated high-quality tests that would catch regressions, or explained why tests were not needed

AI Review Report

Summarize the code review you ran with your AI coding agent. Include the main risks it checked, what it flagged, and what you changed or verified as a result.
Confirm that the review explicitly checked cross-platform compatibility for macOS, Linux, and Windows, including shortcuts, labels, paths, shell behavior, and any Electron-specific platform differences touched by this PR.

Security Audit

Provide a basic security audit summary from your AI coding agent. Call out any input handling, command execution, path handling, auth, secrets, dependency, or IPC risks that were reviewed, plus any follow-up needed.

Notes

this pr added the features represented in

#1109

@mrayushmehrotra mrayushmehrotra changed the title feat: implement hierarchical tree view for PR diff file list feat: implement hierarchical tree view for PR diff file list fixes #1109 Apr 30, 2026
@Jinwoo-H

Copy link
Copy Markdown
Contributor

Thanks for the PR! Will take a look soon 👍

@Jinwoo-H
Jinwoo-H self-requested a review April 30, 2026 07:58
- Show oldBasename → newBasename for renames in tree view instead of
  hiding them; include parent dir when basenames match so directory-only
  moves aren't displayed as meaningless "foo → foo".
- Add role="tree", role="treeitem", and role="group" ARIA attributes.
- Add tests for empty input, root-only files, renamed files, and
  backslash paths.

Co-authored-by: Orca <help@stably.ai>
@Jinwoo-H

Copy link
Copy Markdown
Contributor

Looks good! I pushed a small follow-up: tree view now shows rename info (e.g. old.ts → new.ts) instead of just the new basename, added ARIA tree roles for accessibility, and added a few more test cases.

@Jinwoo-H
Jinwoo-H merged commit 8e5114a into stablyai:main Apr 30, 2026
2 checks passed
@mrayushmehrotra

Copy link
Copy Markdown
Author

thank you @Jinwoo-H

mralexsaavedra pushed a commit to mralexsaavedra/orca that referenced this pull request May 2, 2026
…ablyai#1109 (stablyai#1278)

Co-authored-by: Orca <help@stably.ai>
Co-authored-by: Jinwoo-H <jinwoo0825@gmail.com>
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
…ablyai#1109 (stablyai#1278)

Co-authored-by: Orca <help@stably.ai>
Co-authored-by: Jinwoo-H <jinwoo0825@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants