Repository navigation
fix(mac-perms): fall through to Privacy pane when in-app prompt is a no-op - #1273
Merged
Merged
Conversation
…no-op askForMediaAccess only surfaces the TCC dialog when the current status is 'not-determined'. If the user has previously denied mic/camera access, clicking Request in Settings → Permissions resolved silently: the renderer showed a "Permission request sent" toast while nothing actually happened. isTrustedAccessibilityClient(true) has the same one-shot behavior. When the in-app API cannot grant access, open the matching Privacy & Security pane so the user can toggle the permission themselves. Co-authored-by: Orca <help@stably.ai>
After clicking Request, the user flips a toggle in macOS System Settings and returns to Orca. Without this, the chip stays stale until they hit Refresh manually — a silent UX trap that makes the fix look broken. Refresh on window focus rather than on a polling interval so the pane doesn't keep calling into `systemPreferences` while it sits idle. Co-authored-by: Orca <help@stably.ai>
5 tasks done
mralexsaavedra
pushed a commit
to mralexsaavedra/orca
that referenced
this pull request
May 2, 2026
…no-op (stablyai#1273) Co-authored-by: Orca <help@stably.ai>
3 tasks done
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
…no-op (stablyai#1273) Co-authored-by: Orca <help@stably.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #1233 shipped the Settings → Permissions pane, clicking Request on Microphone (or Camera) while macOS had the permission set to Denied did nothing visible except show a toast that read "Permission request sent". No TCC dialog appeared, and the user had no way to actually toggle the permission on from Orca.
Root cause:
systemPreferences.askForMediaAccess(type)only surfaces the macOS prompt when the current status is'not-determined'. If the user has already denied (or the status is otherwise non-pending), the API resolvesfalsewith no side effect. The IPC handler was returningopenedSystemSettings: falsein that case, which hit the generic fallback toast in the renderer.systemPreferences.isTrustedAccessibilityClient(true)has the same one-shot behavior for Accessibility.Fix
When the in-app prompt API cannot grant access, open the matching Privacy & Security deep-link pane so the user can flip the permission themselves:
askForMediaAccessresolves false and the status isdenied,restricted, orunknown, open the Privacy → Microphone (or Camera) pane and reportopenedSystemSettings: true— the renderer then shows the correct "Opened macOS Privacy & Security" toast.isTrustedAccessibilityClient(true)returns false, open Privacy → Accessibility the same way.No behavioral change when the in-app prompt can actually grant access:
askForMediaAccesson a'not-determined'status still shows the native TCC dialog as before.Testing
pnpm exec oxlint src/main/ipc/developer-permissions.tspnpm run typecheck:nodeMade with Orca 🐋