Repository navigation
Conversation
Register reasonix (npm-installed terminal coding agent, reasonix@1.19.4) as a launchable TuiAgent: extend the TuiAgent union, TUI_AGENT_CONFIG with detect/launch on the npm bin, telemetry kind, display names, skills CLI mapping, auto-pick order, agent status labels, and the UI catalog plus 5 locale catalogs. promptInjectionMode uses stdin-after-start until the CLI prompt contract is verified.
📝 WalkthroughWalkthroughThe change adds Reasonix to shared agent types, telemetry mappings, display names, skills CLI mappings, runtime configuration, automatic selection, renderer catalog data, icon recognition, and English, Spanish, Japanese, Korean, and Chinese locales. It also adds Reasonix detection and launch settings that use the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@brennanb2025 |
Summary
Adds reasonix (npm-installed terminal coding agent,
reasonix@1.19.4) as a launchable TUI agent provider in Orca.reasonix installs via
npm install -g reasonixand runs as a terminal TUI (reasonix), matching the same model as claude-code / codex / opencode. Orca detects the npm-installed binary on PATH and launches it in a pty like any other agent:TuiAgentmember'reasonix'plus aTUI_AGENT_CONFIGentry (detectCmd/launchCmd=reasonix,promptInjectionMode: 'stdin-after-start')AGENT_KIND_VALUES+TUI_AGENT_KIND_BY_AGENT), display name, skills CLI mapping (falls back to universal), auto-pick order, well-known status labelsUser-visible change: the agent picker / new-tab flow gains a "Reasonix" option; when installed it is detected and launchable like any other agent.
Screenshots
No screenshots available: the authoring environment could not launch Electron (GitHub network timeouts blocked the Electron binary download). The visual change is a single new "Reasonix" entry (letter "R" glyph fallback) in the agent picker; no other UI changes.
Testing
pnpm lint— oxlint 0 warnings / 0 errors;audit:code-quality:native+type-aware0/0; reliability gates (62) pass; max-lines ratchet OKpnpm typecheck— all 3 tsconfigs (node / cli / web) zero errors; everyRecord<TuiAgent, …>table exhaustive (compiler-driven)pnpm test(affected suites) — agent-kind / keybindings / agent-detection / agent-type-label / tui-agent-selection: 146 tests pass; localization catalog verified (en synced, es/ja/ko/zh aligned)pnpm build— not run locally: requires the Electron binary, which could not be downloaded in this environment (network timeout); CIpackagejob covers itagent-kind.test.tssync test,keybindings.test.tsper-agent actions,skills-cli-agent-keys.test.ts); a temp launch-command test verifiedlaunchCmd=reasonixon darwin / linux / win32AI Review Report
Reviewed with an AI coding agent; main risks checked:
detectCmd/launchCmduse the singlereasonixbin on all three platforms (npm installs the platform binary via@reasonix/cli-*optionalDependencies); Windows pty spawn goes through the existing shell-fallback chain. No hardcoded paths, shortcuts, or platform-specific shell behavior introduced.TUI_AGENT_CONFIGpattern only; zero behavior change to existing providers;SKILLS_CLI_AGENT_KEY_BY_TUI_AGENT['reasonix'] = nullsafely drops to the universal target since the skills CLI has no reasonix key.es.jsonentry, missing auto-pick order entry, missing well-known status labels (agent-status-types.ts/agent-type-label.ts).Security Audit
launchCmd: 'reasonix'runs the user-installed binary, same trust model as every existing agent; no flag-injection surface added.Notes
promptInjectionModeis'stdin-after-start'(bare launch + paste) because reasonix's prompt contract is not yet verified; ifreasonix <prompt>or a--prefill-style flag is confirmed, it can be upgraded to'argv'/draftPromptFlagin a follow-up.pnpm testsuite and an interactive reasonix launch inside a hosted pty (Electron binary unavailable in the authoring environment); CI covers both.