Skip to content

fix(editor): save floating workspace markdown files - #10985

Merged
OrcaWin merged 1 commit into
mainfrom
save-not-working-md
Jul 27, 2026
Merged

OrcaWin merged 1 commit into
mainfrom
save-not-working-md

Conversation

@OrcaWin

@OrcaWin OrcaWin commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • preserve the synthetic local owner while revalidating floating workspace file mutations
  • restore Save As renames for newly created floating markdown notes
  • add focused regression coverage for the floating owner round trip

Root cause

Opening a floating markdown note captured explicit local ownership provenance. Save As then revalidated that provenance through repo-backed owner catalogs, where the synthetic floating workspace ID cannot exist, and rejected before the filesystem rename.

Test plan

  • 258 focused editor and ownership-routing tests
  • renderer typecheck
  • targeted oxlint and formatting checks
  • max-lines ratchet check

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cbd89570-1178-4c1b-8c62-6abb8b4505d1

📥 Commits

Reviewing files that changed from the base of the PR and between 94009f6 and fce9794.

📒 Files selected for processing (2)
  • src/renderer/src/lib/editor-file-operation-owner.test.ts
  • src/renderer/src/lib/editor-file-operation-owner.ts

📝 Walkthrough

Walkthrough

Floating workspace worktrees now resolve directly to the local execution host with no runtime environment. A test captures provenance using the floating worktree identifier, reconstructs the editor file operation context, and verifies the expected local host, worktree ID, and synthetic worktree path.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers summary, root cause, and testing, but it omits required Screenshots, AI Review Report, Security Audit, and Notes sections. Add the missing template sections, including screenshots or 'No visual change', AI review details with macOS/Linux/Windows checks, security audit, and notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main fix: saving floating workspace Markdown files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@OrcaWin
OrcaWin merged commit 560f853 into main Jul 27, 2026
2 checks passed
@OrcaWin
OrcaWin deleted the save-not-working-md branch July 27, 2026 19:14
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant