Skip to content

fix(new-workspace): polish Project and Run-on pickers in create dialog - #10120

Merged
nwparker merged 1 commit into
mainfrom
nwparker/wt-dialogs-improve
Jul 23, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/wt-dialogs-improve

Conversation

@nwparker

@nwparker nwparker commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

What

Polish for the New Workspace (create) dialog's Project and Run on pickers, addressing four small UX papercuts.

Screenshots below are rendered from the real ProjectCombobox, WorkspaceRunTargetCombobox, and Input components in an isolated harness (same Tailwind tokens as the app), left = before, right = after.

1 + 2 + 3 — Run on picker

  • Row padding tightened (py-2 → py-1.5) so items aren't so vertically loose.
  • Local machine now uses a Monitor glyph instead of a server icon 😉 (remote/SSH hosts keep the server icon).
  • "Add host" is now a compact single-row footer with one clean divider — matching the Project picker's "Add a new project" — instead of a taller two-line in-list row with an extra separator (the "weird double border").

Light:
run-on light

Dark:
run-on dark

1 — Project picker row padding

Same py-2 → py-1.5 tightening for the Project list.

Light:
project light

Dark:
project dark

4 — Name field color matches the other inputs (light mode)

The smart name field used a transparent fill, so on light mode it read slightly translucent/greyer over the dialog surface while the neighboring comboboxes are solid bg-background. It now uses bg-background (dark mode already matched via dark:bg-input/30). Each image shows before (left) vs after (right) on the translucent dialog surface:

Light:
item4 light

Dark:
item4 dark

How it was verified

  • typecheck:web, oxlint (+ react-doctor), localization catalog/coverage — all clean.
  • NewWorkspaceComposerCard + new-workspace/* tests: 74 passing. Updated one test helper since "Add host" is now a pinned footer button rather than a cmdk row.

Files

  • NewWorkspaceComposerCard.tsx — Run-on row padding, HostRowIcon (Monitor for local), "Add host" footer restructure.
  • ProjectCombobox.tsx — row padding.
  • SmartWorkspaceNameField.tsx — bg-background on the input + selected-source pill.
  • NewWorkspaceComposerCard.test.tsx — helper update for the footer button.

- Tighten combobox row padding (py-2 -> py-1.5) in the Project and Run-on
  lists so items aren't so vertically loose.
- Use a Monitor glyph (not a server) for the local machine in Run-on.
- Pin 'Add host' as a compact single-row footer with one clean divider,
  matching the Project picker's 'Add a new project' footer (removes the
  taller two-line in-list row and its extra separator).
- Give the smart name field a solid bg-background so it matches the other
  inputs on light mode instead of reading translucent over the dialog.

Co-authored-by: Orca <help@stably.ai>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fc1a9a45-99f7-4d69-ae66-cf2cc17ce3c8

📥 Commits

Reviewing files that changed from the base of the PR and between 0b34442 and 6a28db7.

📒 Files selected for processing (4)
  • src/renderer/src/components/NewWorkspaceComposerCard.test.tsx
  • src/renderer/src/components/NewWorkspaceComposerCard.tsx
  • src/renderer/src/components/new-workspace/ProjectCombobox.tsx
  • src/renderer/src/components/new-workspace/SmartWorkspaceNameField.tsx

📝 Walkthrough

Walkthrough

Updated the run target picker to use distinct local-host and server icons, tighter row spacing, and a pinned Add host footer popover. Adjusted separator rendering and updated the related test selector for the footer control. Reduced project option padding and applied explicit background styling to the selected-source pill and workspace name input.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes a useful summary and screenshots, but it misses required template sections like AI Review Report, Security Audit, and Notes. Add the missing template sections: Summary, Screenshots, Testing checklist, AI Review Report with cross-platform checks, Security Audit, and Notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main UI polish in the new-workspace create dialog.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nwparker
nwparker merged commit a29c487 into main Jul 23, 2026
2 checks passed
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
stablyai#10120)

- Tighten combobox row padding (py-2 -> py-1.5) in the Project and Run-on
  lists so items aren't so vertically loose.
- Use a Monitor glyph (not a server) for the local machine in Run-on.
- Pin 'Add host' as a compact single-row footer with one clean divider,
  matching the Project picker's 'Add a new project' footer (removes the
  taller two-line in-list row and its extra separator).
- Give the smart name field a solid bg-background so it matches the other
  inputs on light mode instead of reading translucent over the dialog.

Co-authored-by: Orca <help@stably.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant