Repository navigation
fix(new-workspace): polish Project and Run-on pickers in create dialog - #10120
Merged
Merged
Conversation
- Tighten combobox row padding (py-2 -> py-1.5) in the Project and Run-on lists so items aren't so vertically loose. - Use a Monitor glyph (not a server) for the local machine in Run-on. - Pin 'Add host' as a compact single-row footer with one clean divider, matching the Project picker's 'Add a new project' footer (removes the taller two-line in-list row and its extra separator). - Give the smart name field a solid bg-background so it matches the other inputs on light mode instead of reading translucent over the dialog. Co-authored-by: Orca <help@stably.ai>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughUpdated the run target picker to use distinct local-host and server icons, tighter row spacing, and a pinned Add host footer popover. Adjusted separator rendering and updated the related test selector for the footer control. Reduced project option padding and applied explicit background styling to the selected-source pill and workspace name input. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 27, 2026
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
stablyai#10120) - Tighten combobox row padding (py-2 -> py-1.5) in the Project and Run-on lists so items aren't so vertically loose. - Use a Monitor glyph (not a server) for the local machine in Run-on. - Pin 'Add host' as a compact single-row footer with one clean divider, matching the Project picker's 'Add a new project' footer (removes the taller two-line in-list row and its extra separator). - Give the smart name field a solid bg-background so it matches the other inputs on light mode instead of reading translucent over the dialog. Co-authored-by: Orca <help@stably.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Polish for the New Workspace (create) dialog's Project and Run on pickers, addressing four small UX papercuts.
Screenshots below are rendered from the real
ProjectCombobox,WorkspaceRunTargetCombobox, andInputcomponents in an isolated harness (same Tailwind tokens as the app), left = before, right = after.1 + 2 + 3 — Run on picker
py-2→py-1.5) so items aren't so vertically loose.Monitorglyph instead of a server icon 😉 (remote/SSH hosts keep the server icon).Light:

Dark:

1 — Project picker row padding
Same
py-2→py-1.5tightening for the Project list.Light:

Dark:

4 — Name field color matches the other inputs (light mode)
The smart name field used a transparent fill, so on light mode it read slightly translucent/greyer over the dialog surface while the neighboring comboboxes are solid
bg-background. It now usesbg-background(dark mode already matched viadark:bg-input/30). Each image shows before (left) vs after (right) on the translucent dialog surface:Light:

Dark:

How it was verified
typecheck:web,oxlint(+ react-doctor), localization catalog/coverage — all clean.NewWorkspaceComposerCard+new-workspace/*tests: 74 passing. Updated one test helper since "Add host" is now a pinned footer button rather than a cmdk row.Files
NewWorkspaceComposerCard.tsx— Run-on row padding,HostRowIcon(Monitor for local), "Add host" footer restructure.ProjectCombobox.tsx— row padding.SmartWorkspaceNameField.tsx—bg-backgroundon the input + selected-source pill.NewWorkspaceComposerCard.test.tsx— helper update for the footer button.