Repository navigation
Revert "Preserve Codex [tui] settings across managed CODEX_HOME remirrors (#9475)" - #10085
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughCodex configuration promotion now processes only top-level scalar settings from the TOML preamble. Runtime and system values are compared against stored baselines before updates are generated. A local upsert helper replaces or inserts top-level assignments while preserving line endings and trailing-newline behavior. Structured 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…rors (stablyai#9475)" (stablyai#10085) This reverts commit c8381f3.
…rors (stablyai#9475)" (stablyai#10085) This reverts commit 254ee71.
…ablyai#10213) * Reapply "Preserve Codex [tui] settings across managed CODEX_HOME remirrors (stablyai#9475)" (stablyai#10085) This reverts commit f86e28f. * fix(codex): anchor settings baseline migration
Why
#9475 (unreleased — not in any tag, including v1.4.152) needs a hardened v1→v2 baseline migration before it can ship safely. Review of the follow-up migration work (
fix-p0-codex-tui-baseline) found that making the upgrade conflict-safe requires more design than a release-window patch allows:.orca-config-settings-baseline.jsonhit a three-way ambiguity: a runtime↔system[tui]divergence with no baseline entry to arbitrate it.utimesSyncover\\wsl$failing leaves the tie-break anchor stale, halting all config mirroring for the distro), and after a pause the standoff is resolved by whichever config.toml gets written first for any reason (Codex trust writes, Orca hook-trust promotion) — which can silently overwrite the user's newer~/.codextui edit with a stale value.Reverting is zero-cost to users (the feature never shipped) and unblocks the release. Re-land is tracked in Linear with the full analysis and a proposed content-anchored migration design.
Verification
codex-config-settings-upsert.ts,config-toml-key-path.ts).vitest src/main/codex/: 32 files, 498 passed / 5 skipped.npm run typecheck(node + cli + web) and oxlint clean.Made with Orca 🐋