Repository navigation
Bind mobile markdown creation to file owner - #10083
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds mobile helpers to resolve file-mutation ownership for local and SSH worktrees, including capability checks, worktree host lookup, SSH state retrieval, timeout handling, and validation tests. Updates markdown note creation to capture ownership before retries and include the resolved ownership fields in each 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gal064
pushed a commit
to gal064/orca
that referenced
this pull request
Jul 25, 2026
This was referenced Jul 27, 2026
9 tasks done
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When creating markdown files, bind the file creation operation to the execution host that owns the worktree. This ensures file mutations are routed correctly, especially for SSH-hosted worktrees where the connection generation must be captured at mutation time.
Implementation
Adds
captureMobileFileMutationOwnership()to query the runtime for:Ownership parameters are captured before file creation attempts and passed to the RPC request, ensuring correct routing when retrying with unique filenames.
Screenshots
No visual change
Testing
pnpm test— comprehensive vitest coverage addedbuildMobileFileMutationOwnership(): validates local, remote, and SSH ownership detection with edge casescaptureMobileFileMutationOwnership(): verifies runtime capability checks, SSH state queries, and error handlingNotes
SSH connection generation is live-queried to prevent stale ownership data if the host reconnects between worktree inspection and file creation.