Skip to content

[Bug]: Vietnamese Telex input in integrated terminal loses characters (e.g. "chính" → "ch") #6698

Closed

Description

@phong03bn

Operating system

macOS

Orca version

v1.4.104

Details

Description

When typing Vietnamese text with diacritics in Orca's integrated terminal, characters are lost or corrupted as soon as I add the tone mark at the end.

A typical example using the word “chính”:

  • Using a Vietnamese Telex input method, I type: chinhs (which should produce the Vietnamese word “chính”)
  • However, in Orca’s terminal the final result is only ch — the ính part disappears after the IME commits the composition.

This happens for essentially any Vietnamese word typed with Telex: if I type the full Telex sequence (letters + tone key) so that it should become a Vietnamese word with diacritics, parts of the word are removed or changed once the IME finalizes the composed text.

This makes it effectively impossible to type normal Vietnamese text in the Orca terminal.

Steps to Reproduce

  1. Open Orca and create/open a local terminal.
  2. Enable a Vietnamese Telex input method on the OS (for example: Unikey/EVKey on Windows, or the built‑in Vietnamese IME on macOS/Linux) and set it to Telex mode.
  3. In the Orca terminal, type the Telex sequence for the word “chính”: chinhs.
  4. Observe what is rendered in the terminal.

Actual Behavior

  • The terminal only shows ch, or the rest of the word is otherwise lost/incorrect after the IME commits the composed text.
  • Similar corruption/loss happens for other Vietnamese words typed with Telex.

Expected Behavior

  • The terminal should correctly display the full Vietnamese word with diacritics, for example chính, and in general preserve all characters when the IME commits the composition.

Additional Info

  • This only happens inside Orca’s integrated terminal. Typing Vietnamese with the same IME (Telex) works normally in other apps and terminals outside Orca.
  • The problem appears to be related to how Orca/xterm handles IME composition and updates the buffer when the composed text is committed (especially for multi‑code‑point sequences used in Vietnamese).

Activity

  1. added theissue type on Jul 12, 2026
  2. nwparker commented on Jul 18, 2026

    @nwparker
    Contributor

    Status: NOT REPRODUCED (fixed after report)

    This was filed against v1.4.104. The root cause — xterm's Kitty keyboard encoder canceling the printable keydown before Chromium committed the IME-transformed Vietnamese glyph, dropping everything past the un-transformed prefix (chinhs → ch) — has since been addressed. PRs #6682 (Support Vietnamese IME in terminal forwarder), #6699 (Fix macOS IME input mode detection) and #7102 added a macOS native-text forwarder: a Vietnamese input source enables forwardShortTextReplacements (terminal-ime-input-source.ts), which makes the Telex letter/digit keydown a native-text candidate (terminal-ime-native-text-candidates.ts); the forwarder then claims that keydown to bypass xterm and forwards the committed glyph from the input event straight to the PTY (terminal-ime-native-text-forwarder.ts).

    A repro test drives the real modules with the exact issue word and shows every glyph of chính is forwarded intact (never ch):

    pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/terminal-pane/repro-6698-vietnamese-telex-forwarding.test.ts
    

    4 passed. Full end-to-end confirmation still needs a live macOS app with a real Vietnamese IME, but the code path that caused the loss is remediated. If a residual report appears, likely gaps are a third-party IME whose source id lacks telex/unikey/vietnam/vni, or a tone commit delivered as insertReplacementText (forwarder only handles insertText) — both would be new, narrower issues.


    Automated bug-reproduction pass. Artifact on branch nwparker/bug-repro-pass2; writeup docs/bug-reproductions/6698.md.

  3. added
    pending_reproRepro attempted; still pending conclusive reproduction
    on Jul 18, 2026
  4. AmethystLiang commented on Aug 1, 2026

    @AmethystLiang
    Contributor

    Closing as fixed.

    Merged PRs that close this:

    Maintainer confirmation: filed against v1.4.104; IME forwarder path addresses the Telex character-drop root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingos:macosIssues affecting macOSpending_reproRepro attempted; still pending conclusive reproductionsize/mMedium PR (≤600 added lines, ≤25 files)

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions