You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Bug]: Delete dialog says "No uncommitted changes" when the git status check failed #43678
Windows 11 with WSL2 (project opened via \\wsl.localhost\<distro>\...)
Orca version
1.4.261
Details
What happens
The Delete dialog for a worktree reports "No uncommitted changes" even when Orca's own uncommitted-changes check failed. A failed check is shown as a clean result.
Seen on a worktree that had been removed outside Orca (a ghost row, see #10951), so the folder no longer existed. When the Delete dialog opened, main.trace.ndjson logged both checks failing in that folder:
The dialog says "No uncommitted changes" although git status failed.
Expected
When the status check fails, the dialog says the changes could not be checked (as it already does for ignored files), or says the folder no longer exists. It should never show "No uncommitted changes" without a successful check.
Why it matters
Here the folder was already gone, so nothing was at risk. But any other reason git status can fail (a slow or unreachable WSL mount, a locked index, a permission error) would show a worktree holding real unsaved work as safe to delete.
Taking this. Root cause is in the dialog's status hydration, not the status layer: the store intentionally keeps the last known list when a read fails (gitStatusReadErrorByWorktree, set by setGitStatus), but the delete dialog's useDeleteWorktreeStatusHydration trusted that cached list whenever one existed — so a worktree whose folder was removed outside Orca still carried its pre-removal clean [], and the dialog rendered 'complete' with 0 changes while git status was failing.
Fix: a cached list is only trusted when its last read succeeded (new cachedDeleteStatusIsTrustworthy); otherwise the dialog runs its own fresh check, which publishes null on failure and shows the existing 'Changes could not be checked' copy. PR shortly.
Activity
fix(worktrees): show "Changes could not be checked" when git status f…
fix(worktrees): show "Changes could not be checked" when git status f…
Pr1p commentedon Nov 17, 2026
Taking this. Root cause is in the dialog's status hydration, not the status layer: the store intentionally keeps the last known list when a read fails (
gitStatusReadErrorByWorktree, set bysetGitStatus), but the delete dialog'suseDeleteWorktreeStatusHydrationtrusted that cached list whenever one existed — so a worktree whose folder was removed outside Orca still carried its pre-removal clean[], and the dialog rendered 'complete' with 0 changes whilegit statuswas failing.Fix: a cached list is only trusted when its last read succeeded (new
cachedDeleteStatusIsTrustworthy); otherwise the dialog runs its own fresh check, which publishes null on failure and shows the existing 'Changes could not be checked' copy. PR shortly.