Skip to content

attachHostSessionMirror reports client-side inventory absence as "Remote terminal was closed" #17825

Closed as not planned

Description

@nwparker

Found while fixing #12683 / #12684 (PR #17822); out of scope there.

src/renderer/src/components/terminal-pane/remote-runtime-pty-transport.ts:1057 surfaces "Remote terminal was closed." when hostHandle is falsy — i.e. when the host inventory reports the surface absent, as distinct from undefined meaning no evidence either way.

Absence from a client-side inventory snapshot is not host evidence of exit. Per docs/reference/ssh-execution-boundary.md the verdict vocabulary is live / unverifiable / exited, and this path collapses unverifiable into exited.

The adjacent retireRemoteTerminalId(-1) call sites in the same file get this right and carry explicit comments saying inventory absence is not liveness evidence — so the correct convention is already established a few lines away.

This is very close to what #15141 reports ("healthy rebound remote tab retains a latched 'Remote terminal was closed' error").

Fixing it needs a call on what the host actually publishes when a surface is genuinely removed, versus when the snapshot simply does not contain it — which is why it was not folded into #17822.

Refs #17822, #15141.

Activity

  1. nwparker commented on Sep 2, 2026

    @nwparker
    ContributorAuthor

    Closing — tracking these findings locally rather than in GitHub issues, per repo owner preference. Content preserved outside the tracker. Not closed because it is resolved; the finding stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions