Skip to content

[Bug]: Appearance terminal color overrides affects both light/dark mode #10561

Closed

Description

@Luthiel

Operating system

macOS

Orca version

1.4.155

Details

When I set a background color override for dark mode, the light mode background is also covered/overridden.
I am using an imported Warp theme.

Dark mode terminal color override Light mode incorrectly affected by dark override Appearance settings showing terminal color overrides

Original (中文)

标题: [Bug]: Appearance terminal color overrides affects both light/dark mode

详情: 当我为 dark mode 设置背景色 override 时,light mode 的背景色同样被 cover。我使用的是导入的 warp 主题。

Activity

  1. added theissue type on Jul 25, 2026
  2. nwparker commented on Jul 27, 2026

    @nwparker
    Contributor

    Reproduction confirmed (has_repro)

    Method: Settings schema + theme composition on main.

    Root cause

    GlobalSettings.terminalColorOverrides is a single object (not per light/dark). composeActiveTerminalTheme always merges it onto the active theme:

    // terminal-appearance.ts
    if (settings.terminalColorOverrides) {
      theme = { ...theme, ...settings.terminalColorOverrides }
    }

    UI (TerminalWindowSection.tsx) writes the same shared map for every color field.

    Steps

    1. Appearance → Terminal → Color Overrides (or import a dark Warp/Ghostty theme that sets background).
    2. Set Background override while in dark mode.
    3. Switch app theme to light.
    4. Expected: light theme background.
    5. Actual: dark override still covers light mode.

    Harness: docs/bug-reproductions/10561-terminal-color-overrides-mode/README.md

  3. added
    has_reproConclusive reproduction exists (test/script/CLI evidence). See docs/bug-reproductions/
    on Jul 27, 2026
  4. added a commit that references this issue on Oct 29, 2026
    bc142b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinghas_reproConclusive reproduction exists (test/script/CLI evidence). See docs/bug-reproductions/os:macosIssues affecting macOS

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions