Add refrigerator support - #5
Merged
Merged
Conversation
Owner
|
First of all, thanks for your pull request, I really appreciate it, and sure I'm going to merge this pull request. Well actually it probably is my bad I did not put the eslint rules, what I want to talk about this pull request is it'd be better to keep the convention as it was written, in this case trailing commas. |
ncovercash
added a commit
to ncovercash/wideq-js
that referenced
this pull request
May 8, 2020
This creates a buffer containing the binary information needed to control certain devices. It looks like the initial PR for this (ssut#5) was for a unit which supported certain string-based commands – this is not the case with mine and others (per related sampsyo/wideq#12). This is a dynamic method which will build up the binary control string from the specification and current Status object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.