Force docker to pull FROM images when building - #281
Merged
Conversation
carlosms
approved these changes
Sep 13, 2019
Otherwise, we're building using old versions of our FROM images. some info: https://www.databasesandlife.com/docker-build-pull-option Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
dpordomingo
force-pushed
the
pull-on-build
branch
from
September 16, 2019 07:35
a4dd88e to
2b4e140
Compare
Contributor
|
Given that
|
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Contributor
Author
|
Good idea @se7entyse7en |
se7entyse7en
approved these changes
Sep 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After fixing MariaDB issue #279 we found again that
libmariadbclient18was missing in some others mate's PCs.Turns out that
libmariadbclient18was removed fromdebian buster(base ofpython:3.6-slim), but when building the image with an old version ofpython:3.6andpython:3.6-slim, it failed.The solution appeared deleting current
python:3.6andpython:3.6-slimimages, and building again, which pulled the proper (and new) versions ofpython:3.6andpython:3.6-slim.Adding
--pullin ourdocker buildcommands will do it by default, to avoid building using old versions of our FROM images.some info: https://www.databasesandlife.com/docker-build-pull-option