Skip to content

Force docker to pull FROM images when building - #281

Merged
dpordomingo merged 2 commits into
src-d:masterfrom
dpordomingo:pull-on-build
Sep 16, 2019
Merged

Force docker to pull FROM images when building#281
dpordomingo merged 2 commits into
src-d:masterfrom
dpordomingo:pull-on-build

Conversation

@dpordomingo

Copy link
Copy Markdown
Contributor

After fixing MariaDB issue #279 we found again that libmariadbclient18 was missing in some others mate's PCs.

Turns out that libmariadbclient18 was removed from debian buster (base of python:3.6-slim), but when building the image with an old version of python:3.6 and python:3.6-slim, it failed.

The solution appeared deleting current python:3.6 and python:3.6-slim images, and building again, which pulled the proper (and new) versions of python:3.6 and python:3.6-slim.

Adding --pull in our docker build commands will do it by default, to avoid building using old versions of our FROM images.

some info: https://www.databasesandlife.com/docker-build-pull-option


  • I have updated the CHANGELOG file according to the conventions in keepachangelog.com
  • This PR contains changes that do not require a mention in the CHANGELOG file

@dpordomingo dpordomingo added the bug Something isn't working label Sep 13, 2019
@dpordomingo
dpordomingo requested a review from a team September 13, 2019 12:18
@dpordomingo dpordomingo self-assigned this Sep 13, 2019
Otherwise, we're building using old versions of our FROM images.
some info: https://www.databasesandlife.com/docker-build-pull-option

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@se7entyse7en

Copy link
Copy Markdown
Contributor

Given that --pull means to Always attempt to pull a newer version of the image this could happen again for future versions of debian. Isn't it better to just change the base images as follows?

  • python:3.6 -> python:3.6-buster
  • python:3.6-slim -> python:3.6-slim-buster

@se7entyse7en se7entyse7en mentioned this pull request Sep 16, 2019
2 tasks
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo

Copy link
Copy Markdown
Contributor Author

Good idea @se7entyse7en
Travis running with that locked images from bae02c5

@dpordomingo
dpordomingo merged commit 35b17df into src-d:master Sep 16, 2019
@dpordomingo
dpordomingo deleted the pull-on-build branch September 19, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants