Skip to content

det: refuse a non-digit in a TALLYING counter or STRING/UNSTRING POINTER (Part of #4692) - #5327

Merged
squid-protocol merged 5 commits into
mainfrom
churn/4692-20261017T1034Z
Oct 17, 2026
Merged

squid-protocol merged 5 commits into
mainfrom
churn/4692-20261017T1034Z

Conversation

@squid-protocol

Copy link
Copy Markdown
Owner

Part of #4692 (follows #4889: the receiver of ADD / SUBTRACT / MULTIPLY / DIVIDE).

What

The class is "a statement reads a zoned item's current value before it stores, and the item holds a non-digit". ADD-family receivers already refuse by name; the same read-before-store sites did not. They now go through Cobol.counterNum (refuse by name, Zoned.refuseCounter) on the same IBM ground (no documented result; ZONEDATA(PFD) assumes valid zone bits):

Member Status
ADD / SUBTRACT / MULTIPLY / DIVIDE receiver, incl. lifted plain items already refused (#4889); lifted path now tested
INSPECT ... TALLYING counter refused (this PR)
UNSTRING ... TALLYING IN counter refused (this PR)
STRING / UNSTRING WITH POINTER refused (this PR)
MOVE / GIVING receiver, COMPUTE y = y + 1 overwritten / operand, modelled (unchanged)

A digit-only counter counts as ever. Tests: 5 receiver shapes x 5 operations refused, digit-only starts, plain-item path (test_det_nondigit_zoned.py); register C11 and cobolrt_rules.json (RT-CBL-COUNTER-NONDIGIT-REFUSED) updated; the PCCONF overlay runtime re-synced.

Evidence

Burned estates: every INSPECT TALLYING counter in CardDemo/CBSA/GenApp/zECS/DBB is COMP/BINARY and zeroed first, so no burned port moves (translator untouched). pr_gates --fast 6/6, --ratchets 8/8 pass.

Cross-repo

None.

🤖 Generated with Claude Code

…RING/UNSTRING POINTER (Part of #4692)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-protocol squid-protocol added the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Oct 17, 2026
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol
squid-protocol marked this pull request as ready for review October 17, 2026 10:48
@squid-protocol
squid-protocol enabled auto-merge (squash) October 17, 2026 10:48
@squid-protocol

Copy link
Copy Markdown
Owner Author

PR #5327 @ 2941009: 1 failed check(s)

== crucible (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/39026312855/job/117377878200
repro: tests/tools/box/heavy-run.sh python -m pytest -q tests/cics_crucible && tests/tools/box/heavy-run.sh python tests/tools/cics_crucible.py --ci --out /tmp/gitgalaxy-scratch/ci-digest/cics
failing tests: tests/cics_crucible/test_port_provenance.py::test_a_re_proof_names_the_port_it_proved
errors:
fail-on-cache-miss: false
record says, with a stale mark at the pin, that its latest re-proof failed (#4343: the port is not proven now)."""
E AssertionError: pc-wizard/PCCONF/provenance.json: the port changed since its last re-proof; run tests/tools/crucible_port_provenance.py reprove
tests/cics_crucible/test_port_provenance.py:31: AssertionError
FAILED tests/cics_crucible/test_port_provenance.py::test_a_re_proof_names_the_port_it_proved - AssertionError: pc-wizard/PCCONF/provenance.json: the port changed since its last re-proof; run tests/tools/crucible_port_provenance.py reprove
##[error]Process completed with exit code 1.
log tail:
with:
name: cics-crucible-results
path: /home/runner/work/_temp/cics_crucible
if-no-files-found: ignore
compression-level: 6
overwrite: false
include-hidden-files: false
archive: true
env:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
PYTHONUTF8: 1
pythonLocation: /opt/hostedtoolcache/Python/3.12.15/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib
JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.20-1/x64
JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.20-1/x64
MAVEN_ARGS: -ntp
GITGALAXY_ORACLE_PREBUILT: 1
##[endgroup]
No files were found with the provided path: /home/runner/work/_temp/cics_crucible. No artifacts will be uploaded.
Post job cleanup.
Post job cleanup.
[command]/usr/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/work/_temp/2320e74c-b33c-454f-90da-a246287e26b0' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

@squid-protocol squid-protocol added the shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md label Oct 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🐦‍⬛ Muninn Security Scan

✅ No security issues found.

🐦‍⬛ Powered by Muninn · Skald Lab

… (Part of #4692)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-protocol squid-protocol removed the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Oct 17, 2026
@squid-protocol

Copy link
Copy Markdown
Owner Author

CI shepherd: the head of this PR (65e2b7a) is not the one a maintainer labelled shepherd:merge on (new commits, or never approved), so the label was removed and nothing merges unreviewed code. Re-add the label when the new head is ready (shepherd:reapprove marks this PR until then).

@squid-protocol squid-protocol added shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md and removed shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md labels Oct 17, 2026
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol
squid-protocol enabled auto-merge (squash) October 17, 2026 11:06
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol

Copy link
Copy Markdown
Owner Author

PR #5327 @ 65e2b7a: 2 failed check(s)

== ground-truth (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/39027347087/job/117384031105
repro: python tests/tools/pr_gates.py --ratchets --only-ratchets ground-truth
errors:
##[error]Process completed with exit code 1.
log tail:
Commit: f3dc54e1fb89da6852db922499a0233137369e1d
Build Date: 2026-10-12T17:48:21Z
Worker ID: {2672dedf-f3a8-4fce-a985-007e6a84b58a}
Region: eastus2
Cloud: Azure
##[endgroup]
##[group]Operating System
Ubuntu
24.04.5
LTS
##[endgroup]
##[group]Runner Image
Image: ubuntu-24.04
Version: 20261012.334.1
Included Software: https://github.com/actions/runner-images/blob/ubuntu24/20261012.334/images/ubuntu/Ubuntu2404-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20261012.334
##[endgroup]
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
##[endgroup]
Secret source: Actions
Cache mode: write
Prepare workflow directory
Prepare all required actions
Complete job name: ground-truth
##[group]Run echo "ground-truth parts: $PARTS (tested-tree skip: $SKIP, plan mode: $MODE)"
echo "ground-truth parts: $PARTS (tested-tree skip: $SKIP, plan mode: $MODE)"
# #4935: "skipped" is a pass only when the gate proved this tree green on the PR; otherwise it is a failure
# #5164: ... or when the plan found no ground-truth input in the PR (mode none). An empty mode is not none.
test "$PARTS" = "success" || { test "$PARTS" = "skipped" && { test "$SKIP" = "true" || test "$MODE" = "none"; }; }
shell: /usr/bin/bash -e {0}
env:
PARTS: failure
SKIP:
MODE: full
##[endgroup]
ground-truth parts: failure (tested-tree skip: , plan mode: full)
##[error]Process completed with exit code 1.
Cleaning up orphan processes

== ground-truth part 1/2 (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/39027347087/job/117381362816
repro: python tests/tools/pr_gates.py --fast
failing tests: tests/cobol_mainframe/test_evidence.py::test_every_committed_record_is_current
errors:
fail-on-cache-miss: false
E AssertionError: re-prove these in this PR (python tests/tools/evidence.py prove KEY):
tests/cobol_mainframe/test_evidence.py:49: AssertionError
FAILED tests/cobol_mainframe/test_evidence.py::test_every_committed_record_is_current - AssertionError: re-prove these in this PR (python tests/tools/evidence.py prove KEY):
##[error]Process completed with exit code 1.
log tail:
archive: true
env:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
GITGALAXY_MAINFRAME_CORPORA: /home/runner/work/gitgalaxy/gitgalaxy/.mainframe_corpora
PYTHONUTF8: 1
pythonLocation: /opt/hostedtoolcache/Python/3.12.15/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib
##[endgroup]
With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Uploading artifact: test-times-ground-truth-part-1.zip
Beginning upload of artifact content to blob storage
Uploaded bytes 137070
Finished uploading artifact content to blob storage!
SHA256 digest of uploaded artifact is 179e5f4c24e687010c7dfe3dc9504b6d64f0735fcfc971b57218901f0d3db030
Finalizing artifact upload
Artifact test-times-ground-truth-part-1 successfully finalized. Artifact ID 12099312578
Artifact test-times-ground-truth-part-1 has been successfully uploaded! Final size is 137070 bytes. Artifact ID is 12099312578
Artifact download URL: https://github.com/squid-protocol/gitgalaxy/actions/runs/39027347087/artifacts/12099312578
Post job cleanup.
[command]/usr/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/work/_temp/04da0cc7-fee5-4daa-9819-cfb41c369d49' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

@squid-protocol squid-protocol added the shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md label Oct 17, 2026
squid-protocol and others added 2 commits October 17, 2026 07:30
…Part of #4692)

test_every_committed_record_is_current failed: both ports changed since their proofs.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-protocol

Copy link
Copy Markdown
Owner Author

CI shepherd: the head of this PR (7049d87) is not the one a maintainer labelled shepherd:merge on (new commits, or never approved), so the label was removed and nothing merges unreviewed code. Re-add the label when the new head is ready (shepherd:reapprove marks this PR until then).

@squid-protocol squid-protocol removed the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Oct 17, 2026
@squid-protocol squid-protocol added shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md and removed shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md labels Oct 17, 2026
@squid-protocol squid-protocol removed the shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md label Oct 17, 2026
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol
squid-protocol enabled auto-merge (squash) October 17, 2026 11:37
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol
squid-protocol merged commit 7ecb0e2 into main Oct 17, 2026
61 checks passed
@squid-protocol
squid-protocol deleted the churn/4692-20261017T1034Z branch October 17, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant