Repository navigation
ci: Generated Java same-base cache keyed on generation-input content (Part of #5137, #5142) - #5190
Merged
Merged
Conversation
…content (Part of #5137, #5142) The key was the base commit; only ~43% of main commits have an entry (the push run is path-filtered), so most PRs missed and regenerated both sides. Key it on hashFiles of the paths: list (the PR's base checkout, or main's own on a push). Also fix the MGT header's "well under a minute" (2-4 min cold). Owner-approved patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
squid-protocol
added
the
shepherd:merge
Owner
Author
|
No description provided. |
squid-protocol
marked this pull request as ready for review
October 15, 2026 12:55
squid-protocol
enabled auto-merge (squash)
October 15, 2026 12:57
Owner
Author
|
No description provided. |
Contributor
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Owner-approved patch (2026-10-15,
owner-diff-5137-workflows.patch), applied cleanly; only deviation: the java-compile header comment "cached per base commit" now says "per content hash of the generation inputs".java-compile.yml: thejava-same-base-*restore/save key ishashFilesof the generation inputs (thepaths:list plusmainframe_corpus.py) - the PR'sbase/checkout on a PR, main's own checkout on a push. The old key was the base commit, which has an entry only for ~43% of main commits.tests/tools/test_cache_keys.py: same-base test asserts the content-hash key (restore hashesbase/, save hashes main's checkout, save skips PRs).mainframe-ground-truth.yml: header comment "well under a minute" -> 2-4 min cold scan.Gates
test_cache_keys.py51 passed;pr_gates --fast6/6;pr_gates --ratchets8/8. No engine change, no golden bless.Cross-repo: none.
Lessons for agents
The cache is cold until main's next push touching the generation paths populates the new content key; the first PRs after merge still miss.
🤖 Generated with Claude Code