Skip to content

agy-authored, Sonnet-checked: CICS stub harness Windows portability (64-bit counts/offsets, Windows-aware env) (#5055) - #5070

Merged
squid-protocol merged 7 commits into
mainfrom
churn/5055-20261013T2230Z
Oct 14, 2026
Merged

squid-protocol merged 7 commits into
mainfrom
churn/5055-20261013T2230Z

Conversation

@squid-protocol

Copy link
Copy Markdown
Owner

agy-authored, Sonnet-checked. Closes #5055 (Part of #5012).

Class: Windows (MinGW/LLP64) portability of the CICS C test harness: long holding values past 2^31, and stubs started with a POSIX-only env.

Member Status
ggcics.c RBA offsets, record counts, file sizes, IC timestamps, container order, task numbers widened to long long (agy); RBA > 2^31 test case added
~25 PATH=/usr/bin:/bin call sites in test_cics_runtimes.py all now use _stub_base_env() (checker; agy had skipped it though #5038/#5041 had merged); guard test pins the single literal

Guards: test_the_stub_holds_file_offsets_records_and_timestamps_in_64_bits (text check), test_no_stub_runs_with_a_posix_only_env.

Gates: pr_gates --fast 6/6, --ratchets 7/7; test_cics_runtimes.py 139 passed. No golden-master change (test/stub only).

🤖 Generated with Claude Code

squid-protocol and others added 3 commits October 13, 2026 20:25
…64-bit

On Windows (LLP64 / MinGW), long is 32 bits. Audit remaining long uses in ggcics.c and widen file offsets (RBA), record counts, container sequence/order numbers, and interval control timestamps from long / unsigned long to long long / unsigned long long. Widen strtol and %ld to strtoll and %lld. Add guard tests and an RBA > 2^31 test case in test_cics_runtimes.py.

Part of #5055
…#5055)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-protocol squid-protocol added the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Oct 14, 2026
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol
squid-protocol marked this pull request as ready for review October 14, 2026 00:33
@squid-protocol
squid-protocol enabled auto-merge (squash) October 14, 2026 00:33
@github-actions

Copy link
Copy Markdown
Contributor

🐦‍⬛ Muninn Security Scan

✅ No security issues found.

🐦‍⬛ Powered by Muninn · Skald Lab

@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol

Copy link
Copy Markdown
Owner Author

This PR conflicts with main, so no checks ran. Merge origin/main into it and regenerate generated files with their tools (never hand-merge them), then push.

@squid-protocol squid-protocol added the shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md label Oct 14, 2026
squid-protocol and others added 2 commits October 13, 2026 21:44
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nv (Part of #5055)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-protocol squid-protocol removed shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md labels Oct 14, 2026
@squid-protocol

Copy link
Copy Markdown
Owner Author

CI shepherd: the head of this PR (19e1395) is not the one a maintainer labelled shepherd:merge on (new commits, or never approved), so the label was removed and nothing merges unreviewed code. Re-add the label when the new head is ready (shepherd:reapprove marks this PR until then).

@squid-protocol squid-protocol added the shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md label Oct 14, 2026
squid-protocol and others added 2 commits October 13, 2026 23:38
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… env (Part of #5055)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-protocol squid-protocol added shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md and removed shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md labels Oct 14, 2026
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

1 similar comment
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol
squid-protocol enabled auto-merge (squash) October 14, 2026 03:48
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol
squid-protocol merged commit a17b4d3 into main Oct 14, 2026
54 checks passed
@squid-protocol
squid-protocol deleted the churn/5055-20261013T2230Z branch October 14, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Siblings of #5012: Windows portability of the CICS/LE C test harness (env, 32-bit long)

1 participant