Repository navigation
Fix #3958: Support ASCII code pages and PC-COBOL zoned signs in Target config - #3961
Merged
Merged
Conversation
Allows 'data.code_page' to accept ASCII-family encodings (like shift_jis, utf-8, cp1252) and maps them to the standard PC-COBOL zoned-decimal signs ({ABCDEFGHI / }JKLMNOPQR). Also ensures an unknown or incompatible code page explicitly fails rather than silently misreading signs.
Contributor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try: | ||
| if bytes([0xF0]).decode(cp) == "0": | ||
| return bytes(range(0xC0, 0xCA)).decode(cp), bytes(range(0xD0, 0xDA)).decode(cp) | ||
| except UnicodeDecodeError: |
| try: | ||
| if bytes([0x30]).decode(cp) == "0": | ||
| return "{ABCDEFGHI", "}JKLMNOPQR" | ||
| except UnicodeDecodeError: |
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3958.
Changes:
zoned_sign_characters()to support ASCII-family text encodings (likeshift_jis,utf-8,cp1252) by detecting them based on how they decode0x30.{ABCDEFGHIand}JKLMNOPQR) when an ASCII-family encoding is used.utf-16).