Repository navigation
Answer key: reference-modification spans, a new ledger field (#3649, part 2) - #3676
Merged
Merged
Conversation
…part 2) #3655 made the engine keep each reference modification as written, and the IR reads a CICS program's COMMAREA from those texts. No key checked them. New field `refmod spans`: `L<line> VERB SOURCE(start:length) -> TARGET(start:length)` per reference-modified move, with one spelling on both sides (_norm_refmod: whitespace collapsed, no space around + - * / : ( )). - Key: this tool's own data-move reader. _mv_operands now keeps the refmod text, the top-level parenthesis group with a colon, so a subscript is not a refmod. Its srm / trm flags are unchanged. - Engine: data_move_data.source_refmod_text / target_refmod_text. It is a section of its own, so the reviewed `data moves` units are untouched. Key and engine agree on all 373 units: CardDemo 174, CBSA 95, GENAPP 61, zECS 42, zOE 1. DSF's PL/I uses SUBSTR, not refmods. Tier draft, development_rounds 6. Ledger update: +0 -0, 0 untriaged; check clean. Closes #3649 with part 1 (#3672, RIDFLD). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ZsVaAkb86P5r5JXDC2Y9g
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ZsVaAkb86P5r5JXDC2Y9g
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3649 (part 1 was #3672: CICS RIDFLD).
#3655 (#3670) made the engine keep every reference modification as written, and
program_interfacesreads a CICS program's COMMAREA layout from them (MOVE DFHCOMMAREA(LENGTH OF X + 1:LENGTH OF Y) TO Y). No key checked those texts.New ledger field:
refmod spansL<line> VERB SOURCE(start:length) -> TARGET(start:length)per reference-modified move. Both sides share one spelling via_norm_refmod(whitespace collapsed, no space around+ - * / : ( ))._mv_operandsnow keeps the refmod text: the top-level parenthesis group containing:, so a subscriptX(I)is not a refmod. The existingsrm/trmflags are unchanged.data_move_data.source_refmod_text/target_refmod_text.data movesunits are untouched.Result
All 373 units agree: CardDemo 174, CBSA 95, GENAPP 61, zECS 42, zOE 1. DSF's PL/I uses
SUBSTR, not refmods.development_rounds: 6.ground_truth_ledger.py update: +0 −0, 0 untriaged;check: clean.preflight.py: all gates PASS. 553 mainframe tests.With #3672 this closes the gap the #3617 consumer audit found: the byte positions the Java generators depend on (copybook layouts, RIDFLD, refmod spans) now have independent key checks. They go from draft to a verified tier with a census, which is next.
🤖 Generated with Claude Code
https://claude.ai/code/session_017ZsVaAkb86P5r5JXDC2Y9g