Repository navigation
uow_handlers: RESP codes tested by number are checks too (#3453 follow-up) - #3469
Merged
Merged
Conversation
…w-up) The section census surfaced it: CardDemo COSGN00C tests its READ's RESP with `EVALUATE WS-RESP-CD WHEN 0 ... WHEN 13` -- NORMAL and NOTFND by number -- and both the engine and the key read that as "never tested". A RESP_CHECK now also counts `v [NOT] = n` / `v [NOT] EQUAL [TO] n` and the `WHEN n` arms of `EVALUATE v` itself (depth-tracked: a nested EVALUATE's arms test something else, so CREACC's month EVALUATE is not read as RESP codes). Codes are named through the EIBRESP table (0 NORMAL, 13 NOTFND, 22 LENGERR, ...); an unlisted number is kept as the number. The numeric forms name the field themselves, so they read the whole RESP window. The key reader gains the same reading with its own code and its own code table. Exactly one fact moves in either corpus: COSGN00C L211 READ -> NORMAL, NOTFND, the reading its blind census reviewer reported; the signed entry is updated in place with a verification note. Golden masters: that one field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ZsVaAkb86P5r5JXDC2Y9g
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3453, surfaced by the section census (#3467).
CardDemo's COSGN00C tests its READ's RESP by number:
EVALUATE WS-RESP-CD WHEN 0 ... WHEN 13, which is NORMAL and NOTFND. The engine and the key both read that as "never tested".Change
A RESP check now also counts:
v [NOT] = nandv [NOT] EQUAL [TO] n;WHEN narms ofEVALUATE vitself. The scan tracks nesting depth, because a nested EVALUATE's arms test something else; CREACC'sEVALUATEon a month field, for example, is not read as RESP codes.Codes are named through the EIBRESP table (0 NORMAL, 13 NOTFND, 22 LENGERR, ...). A number not in the table is kept as the number.
The key reader gets the same reading, written independently with its own code table.
Effect
NORMAL,NOTFND. That is the reading the file's blind census reviewer reported. The signed key entry is updated in place, with a verification note.🤖 Generated with Claude Code
https://claude.ai/code/session_017ZsVaAkb86P5r5JXDC2Y9g